Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1252331
| From | Alexei Starovoitov <ast@plumgrid.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH V5 1/1] bpf: control events stored in PERF_EVENT_ARRAY maps trace data output when perf sampling |
| Date | 2015-10-21 01:00 +0200 |
| Message-ID | <qlO2T-10k-21@gated-at.bofh.it> (permalink) |
| References | <qlzwT-5dK-41@gated-at.bofh.it> <qlzwT-5dK-39@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 10/20/15 12:22 AM, Kaixu Xia wrote:
> diff --git a/kernel/events/core.c b/kernel/events/core.c
> index b11756f..5219635 100644
> --- a/kernel/events/core.c
> +++ b/kernel/events/core.c
> @@ -6337,6 +6337,9 @@ static int __perf_event_overflow(struct perf_event *event,
> irq_work_queue(&event->pending);
> }
>
> + if (unlikely(!atomic_read(&event->soft_enable)))
> + return 0;
> +
> if (event->overflow_handler)
> event->overflow_handler(event, data, regs);
> else
Peter,
does this part look right or it should be moved right after
if (unlikely(!is_sampling_event(event)))
return 0;
or even to other function?
It feels to me that it should be moved, since we probably don't
want to active throttling, period adjust and event_limit for events
that are in soft_disabled state.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH V5 1/1] bpf: control events stored in PERF_EVENT_ARRAY maps trace data output when perf sampling Kaixu Xia <xiakaixu@huawei.com> - 2015-10-20 09:30 +0200
Re: [PATCH V5 1/1] bpf: control events stored in PERF_EVENT_ARRAY maps trace data output when perf sampling Alexei Starovoitov <ast@plumgrid.com> - 2015-10-21 01:00 +0200
Re: [PATCH V5 1/1] bpf: control events stored in PERF_EVENT_ARRAY maps trace data output when perf sampling Peter Zijlstra <peterz@infradead.org> - 2015-10-21 11:20 +0200
Re: [PATCH V5 1/1] bpf: control events stored in PERF_EVENT_ARRAY maps trace data output when perf sampling xiakaixu <xiakaixu@huawei.com> - 2015-10-21 12:40 +0200
Re: [PATCH V5 1/1] bpf: control events stored in PERF_EVENT_ARRAY maps trace data output when perf sampling Peter Zijlstra <peterz@infradead.org> - 2015-10-21 13:40 +0200
Re: [PATCH V5 1/1] bpf: control events stored in PERF_EVENT_ARRAY maps trace data output when perf sampling "Wangnan (F)" <wangnan0@huawei.com> - 2015-10-21 14:00 +0200
Re: [PATCH V5 1/1] bpf: control events stored in PERF_EVENT_ARRAY maps trace data output when perf sampling Peter Zijlstra <peterz@infradead.org> - 2015-10-21 14:20 +0200
Re: [PATCH V5 1/1] bpf: control events stored in PERF_EVENT_ARRAY maps trace data output when perf sampling "Wangnan (F)" <wangnan0@huawei.com> - 2015-10-21 15:50 +0200
Re: [PATCH V5 1/1] bpf: control events stored in PERF_EVENT_ARRAY maps trace data output when perf sampling Peter Zijlstra <peterz@infradead.org> - 2015-10-21 16:00 +0200
Re: [PATCH V5 1/1] bpf: control events stored in PERF_EVENT_ARRAY maps trace data output when perf sampling pi3orama <pi3orama@163.com> - 2015-10-21 16:10 +0200
Re: [PATCH V5 1/1] bpf: control events stored in PERF_EVENT_ARRAY maps trace data output when perf sampling Peter Zijlstra <peterz@infradead.org> - 2015-10-21 16:10 +0200
Re: [PATCH V5 1/1] bpf: control events stored in PERF_EVENT_ARRAY maps trace data output when perf sampling pi3orama <pi3orama@163.com> - 2015-10-21 17:20 +0200
Re: [PATCH V5 1/1] bpf: control events stored in PERF_EVENT_ARRAY maps trace data output when perf sampling Peter Zijlstra <peterz@infradead.org> - 2015-10-21 19:00 +0200
Re: [PATCH V5 1/1] bpf: control events stored in PERF_EVENT_ARRAY maps trace data output when perf sampling Alexei Starovoitov <ast@plumgrid.com> - 2015-10-21 23:30 +0200
Re: [PATCH V5 1/1] bpf: control events stored in PERF_EVENT_ARRAY maps trace data output when perf sampling Peter Zijlstra <peterz@infradead.org> - 2015-10-22 11:10 +0200
Re: [PATCH V5 1/1] bpf: control events stored in PERF_EVENT_ARRAY maps trace data output when perf sampling "Wangnan (F)" <wangnan0@huawei.com> - 2015-10-22 12:40 +0200
Re: [PATCH V5 1/1] bpf: control events stored in PERF_EVENT_ARRAY maps trace data output when perf sampling Peter Zijlstra <peterz@infradead.org> - 2015-10-23 15:00 +0200
Re: [PATCH V5 1/1] bpf: control events stored in PERF_EVENT_ARRAY maps trace data output when perf sampling Peter Zijlstra <peterz@infradead.org> - 2015-10-23 17:20 +0200
Re: [PATCH V5 1/1] bpf: control events stored in PERF_EVENT_ARRAY maps trace data output when perf sampling xiakaixu <xiakaixu@huawei.com> - 2015-10-27 07:50 +0100
Re: [PATCH V5 1/1] bpf: control events stored in PERF_EVENT_ARRAY maps trace data output when perf sampling "Wangnan (F)" <wangnan0@huawei.com> - 2015-10-22 05:00 +0200
Re: [PATCH V5 1/1] bpf: control events stored in PERF_EVENT_ARRAY maps trace data output when perf sampling Ingo Molnar <mingo@kernel.org> - 2015-10-22 09:50 +0200
Re: [PATCH V5 1/1] bpf: control events stored in PERF_EVENT_ARRAY maps trace data output when perf sampling "Wangnan (F)" <wangnan0@huawei.com> - 2015-10-22 10:00 +0200
Re: [PATCH V5 1/1] bpf: control events stored in PERF_EVENT_ARRAY maps trace data output when perf sampling Peter Zijlstra <peterz@infradead.org> - 2015-10-22 11:30 +0200
Re: [PATCH V5 1/1] bpf: control events stored in PERF_EVENT_ARRAY maps trace data output when perf sampling "Wangnan (F)" <wangnan0@huawei.com> - 2015-10-22 04:10 +0200
Re: [PATCH V5 1/1] bpf: control events stored in PERF_EVENT_ARRAY maps trace data output when perf sampling Alexei Starovoitov <ast@plumgrid.com> - 2015-10-22 05:10 +0200
Re: [PATCH V5 1/1] bpf: control events stored in PERF_EVENT_ARRAY maps trace data output when perf sampling "Wangnan (F)" <wangnan0@huawei.com> - 2015-10-22 05:20 +0200
Re: [PATCH V5 1/1] bpf: control events stored in PERF_EVENT_ARRAY maps trace data output when perf sampling Alexei Starovoitov <ast@plumgrid.com> - 2015-10-22 05:30 +0200
Re: [PATCH V5 1/1] bpf: control events stored in PERF_EVENT_ARRAY maps trace data output when perf sampling Peter Zijlstra <peterz@infradead.org> - 2015-10-22 11:50 +0200
Re: [PATCH V5 1/1] bpf: control events stored in PERF_EVENT_ARRAY maps trace data output when perf sampling "Wangnan (F)" <wangnan0@huawei.com> - 2015-10-21 13:40 +0200
Re: [PATCH V5 1/1] bpf: control events stored in PERF_EVENT_ARRAY maps trace data output when perf sampling Peter Zijlstra <peterz@infradead.org> - 2015-10-21 14:00 +0200
Re: [PATCH V5 1/1] bpf: control events stored in PERF_EVENT_ARRAY maps trace data output when perf sampling "Wangnan (F)" <wangnan0@huawei.com> - 2015-10-21 14:10 +0200
csiph-web