Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1252331
| Path | csiph.com!goblin1!goblin2!goblin.stu.neva.ru!gothmog.csi.it!bofh.it!news.nic.it!robomod |
|---|---|
| From | Alexei Starovoitov <ast@plumgrid.com> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH V5 1/1] bpf: control events stored in PERF_EVENT_ARRAY maps trace data output when perf sampling |
| Date | Wed, 21 Oct 2015 01:00:03 +0200 |
| Message-ID | <qlO2T-10k-21@gated-at.bofh.it> (permalink) |
| References | <qlzwT-5dK-41@gated-at.bofh.it> <qlzwT-5dK-39@gated-at.bofh.it> |
| X-Original-To | Kaixu Xia <xiakaixu@huawei.com>, davem@davemloft.net, acme@kernel.org, mingo@redhat.com, a.p.zijlstra@chello.nl, masami.hiramatsu.pt@hitachi.com, jolsa@kernel.org, daniel@iogearbox.net |
| X-Google-Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=aQRzF3WtruCrLkNd6o+rMZ/zVF0GpfOte8fQQvCDVfE=; b=MM3nEgdmUNKAKfB08PevZg6A7WGQfqWYp+esPZ/tm02/TEhyRt++T1/gCiSyB+grt1 ZyvMvdjT3bOmVuG3SwVg0BbxtzdrtjbAXnCgqaTOFCjyh2N0skwKdZ3GweYUwfJ5AE2E lfXLSpyUCpLPA1EjjZlUL36M6cGhu7AqcmT+e/EcFSudIFN6y6TQ2qpnAIy9bFXbZRnA mV/DPmP/81lYOY/KvP+YB8hT0ermXKCCCkkP/gQWhHkDFyyedg39BM+QUJiQdKS61Hmw 51vfYvEnaCFIlUzSeGlRIVfr+VInllJzapMQaHrrLcoVkUPESBf/J6F2vZ0O59z4oZw1 OLQg== |
| X-Gm-Message-State | ALoCoQmOrcb9RZi6UW0DdOlynvzIaiPzU9dPrQFty0OiglUotnPbhn0fYZpyj24IiJ6KN3LYkodY |
| X-Received | by 10.66.142.106 with SMTP id rv10mr4697023pab.29.1445381586822; Tue, 20 Oct 2015 15:53:06 -0700 (PDT) |
| User-Agent | Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=windows-1252; format=flowed |
| Content-Transfer-Encoding | 7bit |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 31 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | wangnan0@huawei.com, linux-kernel@vger.kernel.org, pi3orama@163.com, hekuang@huawei.com, netdev@vger.kernel.org |
| X-Original-Date | Tue, 20 Oct 2015 15:53:02 -0700 |
| X-Original-Message-ID | <5626C5CE.8080809@plumgrid.com> |
| X-Original-References | <1445325735-121694-1-git-send-email-xiakaixu@huawei.com> <1445325735-121694-2-git-send-email-xiakaixu@huawei.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1252331 |
Show key headers only | View raw
On 10/20/15 12:22 AM, Kaixu Xia wrote:
> diff --git a/kernel/events/core.c b/kernel/events/core.c
> index b11756f..5219635 100644
> --- a/kernel/events/core.c
> +++ b/kernel/events/core.c
> @@ -6337,6 +6337,9 @@ static int __perf_event_overflow(struct perf_event *event,
> irq_work_queue(&event->pending);
> }
>
> + if (unlikely(!atomic_read(&event->soft_enable)))
> + return 0;
> +
> if (event->overflow_handler)
> event->overflow_handler(event, data, regs);
> else
Peter,
does this part look right or it should be moved right after
if (unlikely(!is_sampling_event(event)))
return 0;
or even to other function?
It feels to me that it should be moved, since we probably don't
want to active throttling, period adjust and event_limit for events
that are in soft_disabled state.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH V5 1/1] bpf: control events stored in PERF_EVENT_ARRAY maps trace data output when perf sampling Kaixu Xia <xiakaixu@huawei.com> - 2015-10-20 09:30 +0200
Re: [PATCH V5 1/1] bpf: control events stored in PERF_EVENT_ARRAY maps trace data output when perf sampling Alexei Starovoitov <ast@plumgrid.com> - 2015-10-21 01:00 +0200
Re: [PATCH V5 1/1] bpf: control events stored in PERF_EVENT_ARRAY maps trace data output when perf sampling Peter Zijlstra <peterz@infradead.org> - 2015-10-21 11:20 +0200
Re: [PATCH V5 1/1] bpf: control events stored in PERF_EVENT_ARRAY maps trace data output when perf sampling xiakaixu <xiakaixu@huawei.com> - 2015-10-21 12:40 +0200
Re: [PATCH V5 1/1] bpf: control events stored in PERF_EVENT_ARRAY maps trace data output when perf sampling Peter Zijlstra <peterz@infradead.org> - 2015-10-21 13:40 +0200
Re: [PATCH V5 1/1] bpf: control events stored in PERF_EVENT_ARRAY maps trace data output when perf sampling "Wangnan (F)" <wangnan0@huawei.com> - 2015-10-21 14:00 +0200
Re: [PATCH V5 1/1] bpf: control events stored in PERF_EVENT_ARRAY maps trace data output when perf sampling Peter Zijlstra <peterz@infradead.org> - 2015-10-21 14:20 +0200
Re: [PATCH V5 1/1] bpf: control events stored in PERF_EVENT_ARRAY maps trace data output when perf sampling "Wangnan (F)" <wangnan0@huawei.com> - 2015-10-21 15:50 +0200
Re: [PATCH V5 1/1] bpf: control events stored in PERF_EVENT_ARRAY maps trace data output when perf sampling Peter Zijlstra <peterz@infradead.org> - 2015-10-21 16:00 +0200
Re: [PATCH V5 1/1] bpf: control events stored in PERF_EVENT_ARRAY maps trace data output when perf sampling pi3orama <pi3orama@163.com> - 2015-10-21 16:10 +0200
Re: [PATCH V5 1/1] bpf: control events stored in PERF_EVENT_ARRAY maps trace data output when perf sampling Peter Zijlstra <peterz@infradead.org> - 2015-10-21 16:10 +0200
Re: [PATCH V5 1/1] bpf: control events stored in PERF_EVENT_ARRAY maps trace data output when perf sampling pi3orama <pi3orama@163.com> - 2015-10-21 17:20 +0200
Re: [PATCH V5 1/1] bpf: control events stored in PERF_EVENT_ARRAY maps trace data output when perf sampling Peter Zijlstra <peterz@infradead.org> - 2015-10-21 19:00 +0200
Re: [PATCH V5 1/1] bpf: control events stored in PERF_EVENT_ARRAY maps trace data output when perf sampling Alexei Starovoitov <ast@plumgrid.com> - 2015-10-21 23:30 +0200
Re: [PATCH V5 1/1] bpf: control events stored in PERF_EVENT_ARRAY maps trace data output when perf sampling Peter Zijlstra <peterz@infradead.org> - 2015-10-22 11:10 +0200
Re: [PATCH V5 1/1] bpf: control events stored in PERF_EVENT_ARRAY maps trace data output when perf sampling "Wangnan (F)" <wangnan0@huawei.com> - 2015-10-22 12:40 +0200
Re: [PATCH V5 1/1] bpf: control events stored in PERF_EVENT_ARRAY maps trace data output when perf sampling Peter Zijlstra <peterz@infradead.org> - 2015-10-23 15:00 +0200
Re: [PATCH V5 1/1] bpf: control events stored in PERF_EVENT_ARRAY maps trace data output when perf sampling Peter Zijlstra <peterz@infradead.org> - 2015-10-23 17:20 +0200
Re: [PATCH V5 1/1] bpf: control events stored in PERF_EVENT_ARRAY maps trace data output when perf sampling xiakaixu <xiakaixu@huawei.com> - 2015-10-27 07:50 +0100
Re: [PATCH V5 1/1] bpf: control events stored in PERF_EVENT_ARRAY maps trace data output when perf sampling "Wangnan (F)" <wangnan0@huawei.com> - 2015-10-22 05:00 +0200
Re: [PATCH V5 1/1] bpf: control events stored in PERF_EVENT_ARRAY maps trace data output when perf sampling Ingo Molnar <mingo@kernel.org> - 2015-10-22 09:50 +0200
Re: [PATCH V5 1/1] bpf: control events stored in PERF_EVENT_ARRAY maps trace data output when perf sampling "Wangnan (F)" <wangnan0@huawei.com> - 2015-10-22 10:00 +0200
Re: [PATCH V5 1/1] bpf: control events stored in PERF_EVENT_ARRAY maps trace data output when perf sampling Peter Zijlstra <peterz@infradead.org> - 2015-10-22 11:30 +0200
Re: [PATCH V5 1/1] bpf: control events stored in PERF_EVENT_ARRAY maps trace data output when perf sampling "Wangnan (F)" <wangnan0@huawei.com> - 2015-10-22 04:10 +0200
Re: [PATCH V5 1/1] bpf: control events stored in PERF_EVENT_ARRAY maps trace data output when perf sampling Alexei Starovoitov <ast@plumgrid.com> - 2015-10-22 05:10 +0200
Re: [PATCH V5 1/1] bpf: control events stored in PERF_EVENT_ARRAY maps trace data output when perf sampling "Wangnan (F)" <wangnan0@huawei.com> - 2015-10-22 05:20 +0200
Re: [PATCH V5 1/1] bpf: control events stored in PERF_EVENT_ARRAY maps trace data output when perf sampling Alexei Starovoitov <ast@plumgrid.com> - 2015-10-22 05:30 +0200
Re: [PATCH V5 1/1] bpf: control events stored in PERF_EVENT_ARRAY maps trace data output when perf sampling Peter Zijlstra <peterz@infradead.org> - 2015-10-22 11:50 +0200
Re: [PATCH V5 1/1] bpf: control events stored in PERF_EVENT_ARRAY maps trace data output when perf sampling "Wangnan (F)" <wangnan0@huawei.com> - 2015-10-21 13:40 +0200
Re: [PATCH V5 1/1] bpf: control events stored in PERF_EVENT_ARRAY maps trace data output when perf sampling Peter Zijlstra <peterz@infradead.org> - 2015-10-21 14:00 +0200
Re: [PATCH V5 1/1] bpf: control events stored in PERF_EVENT_ARRAY maps trace data output when perf sampling "Wangnan (F)" <wangnan0@huawei.com> - 2015-10-21 14:10 +0200
csiph-web