Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1251634
| From | Konstantin Shkolnyy <konstantin.shkolnyy@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 1/2] USB: serial: cp210x: Implement 16-bit register access functions |
| Date | 2015-10-20 14:30 +0200 |
| Message-ID | <qlEdc-3CF-7@gated-at.bofh.it> (permalink) |
| References | <qlqMW-R1-7@gated-at.bofh.it> <qlyUa-4cB-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tue, Oct 20, 2015 at 1:45 AM, Oliver Neukum <oneukum@suse.com> wrote:
> On Mon, 2015-10-19 at 17:01 -0500, Konstantin Shkolnyy wrote:
[...]
>> +static int cp210x_read_u16_reg(struct usb_serial *serial, u8 req, u16 *pval)
>> +{
>> + struct cp210x_serial_private *spriv = usb_get_serial_data(serial);
>> + __le16 le16_value;
>
> 1. If you already get passed a pointer to a buffer, why use another
> buffer?
Because I want to preserve the caller's value in the case of an error.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 1/2] USB: serial: cp210x: Implement 16-bit register access functions Konstantin Shkolnyy <konstantin.shkolnyy@gmail.com> - 2015-10-20 00:10 +0200
Re: [PATCH 1/2] USB: serial: cp210x: Implement 16-bit register access functions Oliver Neukum <oneukum@suse.com> - 2015-10-20 08:50 +0200
Re: [PATCH 1/2] USB: serial: cp210x: Implement 16-bit register access functions Konstantin Shkolnyy <konstantin.shkolnyy@gmail.com> - 2015-10-20 14:30 +0200
Re: [PATCH 1/2] USB: serial: cp210x: Implement 16-bit register access functions Johan Hovold <johan@kernel.org> - 2015-10-20 09:50 +0200
Re: [PATCH 1/2] USB: serial: cp210x: Implement 16-bit register access functions Konstantin Shkolnyy <konstantin.shkolnyy@gmail.com> - 2015-10-20 15:00 +0200
Re: [PATCH 1/2] USB: serial: cp210x: Implement 16-bit register access functions Johan Hovold <johan@kernel.org> - 2015-10-20 15:10 +0200
Re: [PATCH 1/2] USB: serial: cp210x: Implement 16-bit register access functions Konstantin Shkolnyy <konstantin.shkolnyy@gmail.com> - 2015-10-20 16:20 +0200
Re: [PATCH 1/2] USB: serial: cp210x: Implement 16-bit register access functions Johan Hovold <johan@kernel.org> - 2015-10-20 18:30 +0200
Re: [PATCH 1/2] USB: serial: cp210x: Implement 16-bit register access functions Konstantin Shkolnyy <konstantin.shkolnyy@gmail.com> - 2015-10-20 19:30 +0200
Re: [PATCH 1/2] USB: serial: cp210x: Implement 16-bit register access functions Konstantin Shkolnyy <konstantin.shkolnyy@gmail.com> - 2015-10-20 19:50 +0200
csiph-web