Re: [PATCH 1/2] USB: serial: cp210x: Implement 16-bit register access functions

Path	csiph.com!goblin2!goblin.stu.neva.ru!aioe.org!bofh.it!news.nic.it!robomod
From	Konstantin Shkolnyy <konstantin.shkolnyy@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] USB: serial: cp210x: Implement 16-bit register access functions
Date	Tue, 20 Oct 2015 14:30:02 +0200
Message-ID	<qlEdc-3CF-7@gated-at.bofh.it> (permalink)
References	<qlqMW-R1-7@gated-at.bofh.it> <qlyUa-4cB-9@gated-at.bofh.it>
X-Original-To	Oliver Neukum <oneukum@suse.com>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=9wo7l2r3GSttm/FqqT2oPNuvaG1SoDFx/WpVX5kk9Og=; b=ymgs2oi4OyfBQ0hc7zZs9vZJpX3fhQjTXKt8N+9NBgdo0mJD7Pcv9m/hD5GcpdjDso ov9hbx/uymOQc+bUhhriaWC3TTtSvWtPykYP3W/saMx8LwdrB3os5+uEk6lTtiiSLk1J 271mV0dghFWvvYUQMbumA6I09A14k7gA/xPOMOXF+PUn6pZL1XCEzSdoxdXn1vk1lQLo vM2s0ftI4MgGKV52aYXeggt14Nx7Ojay4vEJawdSBovpMuOqsvMwonDqcjgEMMEmwRX3 ypL3r5GUDFLwEh6vQrxG6Gm0kSwcou2sDpcF7tMCkjqIYKiHtbYGfyHR6Ld5LQfWkfU4 8KsA==
MIME-Version	1.0
X-Received	by 10.202.77.142 with SMTP id a136mr1558083oib.123.1445343617140; Tue, 20 Oct 2015 05:20:17 -0700 (PDT)
Content-Type	text/plain; charset=UTF-8
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	17
Organization	linux.* mail to news gateway
X-Original-Cc	Johan Hovold <johan@kernel.org>, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
X-Original-Date	Tue, 20 Oct 2015 07:20:17 -0500
X-Original-Message-ID	<CAL_jEz8Q_5cwfrBKvqGg5TMPnv-AcsF++hYcumNxyPA69bLW3g@mail.gmail.com>
X-Original-References	<1445292084-27910-1-git-send-email-konstantin.shkolnyy@gmail.com> <1445323506.2246.6.camel@suse.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1251634

Show key headers only | View raw

On Tue, Oct 20, 2015 at 1:45 AM, Oliver Neukum <oneukum@suse.com> wrote:
> On Mon, 2015-10-19 at 17:01 -0500, Konstantin Shkolnyy wrote:
[...]
>> +static int cp210x_read_u16_reg(struct usb_serial *serial, u8 req, u16 *pval)
>> +{
>> +     struct cp210x_serial_private *spriv = usb_get_serial_data(serial);
>> +     __le16 le16_value;
>
> 1. If you already get passed a pointer to a buffer, why use another
> buffer?

Because I want to preserve the caller's value in the case of an error.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH 1/2] USB: serial: cp210x: Implement 16-bit register access functions Konstantin Shkolnyy <konstantin.shkolnyy@gmail.com> - 2015-10-20 00:10 +0200
  Re: [PATCH 1/2] USB: serial: cp210x: Implement 16-bit register  access functions Oliver Neukum <oneukum@suse.com> - 2015-10-20 08:50 +0200
    Re: [PATCH 1/2] USB: serial: cp210x: Implement 16-bit register access functions Konstantin Shkolnyy <konstantin.shkolnyy@gmail.com> - 2015-10-20 14:30 +0200
  Re: [PATCH 1/2] USB: serial: cp210x: Implement 16-bit register  access functions Johan Hovold <johan@kernel.org> - 2015-10-20 09:50 +0200
    Re: [PATCH 1/2] USB: serial: cp210x: Implement 16-bit register access functions Konstantin Shkolnyy <konstantin.shkolnyy@gmail.com> - 2015-10-20 15:00 +0200
      Re: [PATCH 1/2] USB: serial: cp210x: Implement 16-bit register  access functions Johan Hovold <johan@kernel.org> - 2015-10-20 15:10 +0200
        Re: [PATCH 1/2] USB: serial: cp210x: Implement 16-bit register access functions Konstantin Shkolnyy <konstantin.shkolnyy@gmail.com> - 2015-10-20 16:20 +0200
          Re: [PATCH 1/2] USB: serial: cp210x: Implement 16-bit register  access functions Johan Hovold <johan@kernel.org> - 2015-10-20 18:30 +0200
            Re: [PATCH 1/2] USB: serial: cp210x: Implement 16-bit register access functions Konstantin Shkolnyy <konstantin.shkolnyy@gmail.com> - 2015-10-20 19:30 +0200
            Re: [PATCH 1/2] USB: serial: cp210x: Implement 16-bit register access functions Konstantin Shkolnyy <konstantin.shkolnyy@gmail.com> - 2015-10-20 19:50 +0200

csiph-web