Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1245200

Re: [PATCH v5] mm, dax: fix DAX deadlocks

From Dave Chinner <david@fromorbit.com>
Newsgroups linux.kernel
Subject Re: [PATCH v5] mm, dax: fix DAX deadlocks
Date 2015-10-13 01:00 +0200
Message-ID <qiUeu-4ES-5@gated-at.bofh.it> (permalink)
References <qh5QJ-1Wj-1@gated-at.bofh.it> <qh5QK-1Wj-15@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Wed, Oct 07, 2015 at 04:58:49PM -0600, Ross Zwisler wrote:
> The following two locking commits in the DAX code:
> 
> commit 843172978bb9 ("dax: fix race between simultaneous faults")
> commit 46c043ede471 ("mm: take i_mmap_lock in unmap_mapping_range() for DAX")
> 
> introduced a number of deadlocks and other issues which need to be fixed
> for the v4.3 kernel. The list of issues in DAX after these commits (some
> newly introduced by the commits, some preexisting) can be found here:
> 
> https://lkml.org/lkml/2015/9/25/602
> 
> This undoes most of the changes introduced by those two commits,
> essentially returning us to the DAX locking scheme that was used in v4.2.
> 
> Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com>

I've run this through some testing, the deadlocks aren't present and
there don't appear to be any new regressions, so IMO this is fine to
go to Linus.

Tested-by: Dave Chinner <dchinner@redhat.com>

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread


Thread

[PATCH v5] Fix DAX deadlocks for v4.3 Ross Zwisler <ross.zwisler@linux.intel.com> - 2015-10-08 01:00 +0200
  [PATCH v5] mm, dax: fix DAX deadlocks Ross Zwisler <ross.zwisler@linux.intel.com> - 2015-10-08 01:00 +0200
    Re: [PATCH v5] mm, dax: fix DAX deadlocks Dave Chinner <david@fromorbit.com> - 2015-10-13 01:00 +0200

csiph-web