Re: [PATCH v5] mm, dax: fix DAX deadlocks

Path	csiph.com!optima2.xanadu-bbs.net!xanadu-bbs.net!news.glorb.com!diesel.cu.mi.it!bofh.it!news.nic.it!robomod
From	Dave Chinner <david@fromorbit.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v5] mm, dax: fix DAX deadlocks
Date	Tue, 13 Oct 2015 01:00:02 +0200
Message-ID	<qiUeu-4ES-5@gated-at.bofh.it> (permalink)
References	<qh5QJ-1Wj-1@gated-at.bofh.it> <qh5QK-1Wj-15@gated-at.bofh.it>
X-Original-To	Ross Zwisler <ross.zwisler@linux.intel.com>
X-Ironport-Anti-Spam-Filtered	true
X-Ironport-Anti-Spam-Result	A2DpFQBfORxWPCSkLHldgyZUbqkgAQEBAQEBBosbhRqGCh2CdoIKeQICAQECgTRNAQEBAQEBBwEBAQFBP0EGg2ABAQQ6HCMQCAMYCSUPBSUDBxoTiC0OwAkBAQEBAQEBAwEBAQEBGQQZhhOFRYJugh8HgxqBFAWWE4UZh3mcC4R5KjMBhDyCNAEBAQ
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.21 (2010-09-15)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	34
Organization	linux.* mail to news gateway
X-Original-Cc	linux-kernel@vger.kernel.org, Alexander Viro <viro@zeniv.linux.org.uk>, Matthew Wilcox <willy@linux.intel.com>, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>, Dan Williams <dan.j.williams@intel.com>, Jan Kara <jack@suse.com>, "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>, linux-nvdimm@lists.01.org, Matthew Wilcox <matthew.r.wilcox@intel.com>
X-Original-Date	Tue, 13 Oct 2015 09:53:27 +1100
X-Original-Message-ID	<20151012225327.GF27164@dastard>
X-Original-References	<1444258729-21974-1-git-send-email-ross.zwisler@linux.intel.com> <1444258729-21974-2-git-send-email-ross.zwisler@linux.intel.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1245200

Show key headers only | View raw

On Wed, Oct 07, 2015 at 04:58:49PM -0600, Ross Zwisler wrote:
> The following two locking commits in the DAX code:
> 
> commit 843172978bb9 ("dax: fix race between simultaneous faults")
> commit 46c043ede471 ("mm: take i_mmap_lock in unmap_mapping_range() for DAX")
> 
> introduced a number of deadlocks and other issues which need to be fixed
> for the v4.3 kernel. The list of issues in DAX after these commits (some
> newly introduced by the commits, some preexisting) can be found here:
> 
> https://lkml.org/lkml/2015/9/25/602
> 
> This undoes most of the changes introduced by those two commits,
> essentially returning us to the DAX locking scheme that was used in v4.2.
> 
> Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com>

I've run this through some testing, the deadlocks aren't present and
there don't appear to be any new regressions, so IMO this is fine to
go to Linus.

Tested-by: Dave Chinner <dchinner@redhat.com>

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v5] Fix DAX deadlocks for v4.3 Ross Zwisler <ross.zwisler@linux.intel.com> - 2015-10-08 01:00 +0200
  [PATCH v5] mm, dax: fix DAX deadlocks Ross Zwisler <ross.zwisler@linux.intel.com> - 2015-10-08 01:00 +0200
    Re: [PATCH v5] mm, dax: fix DAX deadlocks Dave Chinner <david@fromorbit.com> - 2015-10-13 01:00 +0200

csiph-web