Re: [PATCH 2/5] perf: unwind: pass symbol source to libunwind

From	Jiri Olsa <jolsa@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/5] perf: unwind: pass symbol source to libunwind
Date	2015-10-12 13:30 +0200
Message-ID	<qiJsK-5Ti-11@gated-at.bofh.it> (permalink)
References	<qdp1E-6RN-3@gated-at.bofh.it> <qdp1E-6RN-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sun, Sep 27, 2015 at 08:37:56PM +0200, Rabin Vincent wrote:
> Even if --symfs is used to point to the debug binaries, we send in the
> non-debug filenames to libunwind, which leads to libunwind not finding
> the debug frame.  Fix this.
> 
> Signed-off-by: Rabin Vincent <rabin.vincent@axis.com>

cc-ing Namhyung on this one

jirka

> ---
>  tools/perf/util/unwind-libunwind.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/util/unwind-libunwind.c b/tools/perf/util/unwind-libunwind.c
> index ef799dc..b93bf7f 100644
> --- a/tools/perf/util/unwind-libunwind.c
> +++ b/tools/perf/util/unwind-libunwind.c
> @@ -363,7 +363,7 @@ find_proc_info(unw_addr_space_t as, unw_word_t ip, unw_proc_info_t *pi,
>  			dso__data_put_fd(map->dso);
>  
>  		memset(&di, 0, sizeof(di));
> -		if (dwarf_find_debug_frame(0, &di, ip, base, map->dso->name,
> +		if (dwarf_find_debug_frame(0, &di, ip, base, map->dso->symsrc_filename,
>  					   map->start, map->end))
>  			return dwarf_search_unwind_table(as, ip, &di, pi,
>  							 need_unwind_info, arg);
> -- 
> 1.7.10.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 2/5] perf: unwind: pass symbol source to libunwind Jiri Olsa <jolsa@redhat.com> - 2015-10-12 13:30 +0200
  Re: [PATCH 2/5] perf: unwind: pass symbol source to libunwind Namhyung Kim <namhyung@kernel.org> - 2015-10-12 14:40 +0200
    Re: [PATCH 2/5] perf: unwind: pass symbol source to libunwind Rabin Vincent <rabin.vincent@axis.com> - 2015-10-13 13:00 +0200

csiph-web