Re: [PATCH 2/5] perf: unwind: pass symbol source to libunwind

From	Rabin Vincent <rabin.vincent@axis.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/5] perf: unwind: pass symbol source to libunwind
Date	2015-10-13 13:00 +0200
Message-ID	<qj5th-4gD-29@gated-at.bofh.it> (permalink)
References	<qdp1E-6RN-3@gated-at.bofh.it> <qdp1E-6RN-17@gated-at.bofh.it> <qiJsK-5Ti-11@gated-at.bofh.it> <qiKyt-7s0-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Oct 12, 2015 at 02:35:08PM +0200, Namhyung Kim wrote:
> On Mon, Oct 12, 2015 at 8:24 PM, Jiri Olsa <jolsa@redhat.com> wrote:
> > On Sun, Sep 27, 2015 at 08:37:56PM +0200, Rabin Vincent wrote:
> >> Even if --symfs is used to point to the debug binaries, we send in the
> >> non-debug filenames to libunwind, which leads to libunwind not finding
> >> the debug frame.  Fix this.
> >>
> >> Signed-off-by: Rabin Vincent <rabin.vincent@axis.com>
> >
> > cc-ing Namhyung on this one
> 
> It seems that the dso->symsrc_filename can be NULL and it's unsafe to
> call dwarf_find_debug_frame() with the NULL pointer.  Other than that
> looks good to me.

Thanks, I will change it to fallback to dso->name if
dso->symsrc_filename is NULL.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 2/5] perf: unwind: pass symbol source to libunwind Jiri Olsa <jolsa@redhat.com> - 2015-10-12 13:30 +0200
  Re: [PATCH 2/5] perf: unwind: pass symbol source to libunwind Namhyung Kim <namhyung@kernel.org> - 2015-10-12 14:40 +0200
    Re: [PATCH 2/5] perf: unwind: pass symbol source to libunwind Rabin Vincent <rabin.vincent@axis.com> - 2015-10-13 13:00 +0200

csiph-web