Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1236494

Re: [PATCH 0/2] coredump: make SIGNAL_GROUP_COREDUMP more friendly to oom-killer

From Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Newsgroups linux.kernel
Subject Re: [PATCH 0/2] coredump: make SIGNAL_GROUP_COREDUMP more friendly to oom-killer
Date 2015-09-30 18:20 +0200
Message-ID <qesgO-1GU-31@gated-at.bofh.it> (permalink)
References <qe5tT-2x8-3@gated-at.bofh.it> <qeo3w-3UA-1@gated-at.bofh.it> <qeqoG-7qA-13@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Oleg Nesterov wrote:
> This patch just makes the SIGNAL_GROUP_COREDUMP check in task_will_free_mem()
> a bit more correct wrt CLONE_VM tasks, nothing more.

OK. Then, that's out of what I can understand. But I wish for
some description to PATCH 2/2 about why to change from
"do { } while_each_thread()" to "for_each_thread() { }"
because they seem to traverse differently.



#define __for_each_thread(signal, t)    \
	list_for_each_entry_rcu(t, &(signal)->thread_head, thread_node)

#define for_each_thread(p, t)           \
	__for_each_thread((p)->signal, t)

static inline struct task_struct *next_thread(const struct task_struct *p)
{
	return list_entry_rcu(p->thread_group.next,
			      struct task_struct, thread_group);
}

#define while_each_thread(g, t) \
	while ((t = next_thread(t)) != g)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 0/2] coredump: make SIGNAL_GROUP_COREDUMP more friendly to  oom-killer Oleg Nesterov <oleg@redhat.com> - 2015-09-29 18:00 +0200
  Re: [PATCH 0/2] coredump: make SIGNAL_GROUP_COREDUMP more friendly to oom-killer Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> - 2015-09-30 13:50 +0200
    Re: [PATCH 0/2] coredump: make SIGNAL_GROUP_COREDUMP more friendly  to oom-killer Oleg Nesterov <oleg@redhat.com> - 2015-09-30 16:20 +0200
      Re: [PATCH 0/2] coredump: make SIGNAL_GROUP_COREDUMP more friendly to oom-killer Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> - 2015-09-30 18:20 +0200
        Re: [PATCH 0/2] coredump: make SIGNAL_GROUP_COREDUMP more friendly  to oom-killer Oleg Nesterov <oleg@redhat.com> - 2015-09-30 18:50 +0200

csiph-web