Re: [PATCH 0/2] coredump: make SIGNAL_GROUP_COREDUMP more friendly to oom-killer

From	Oleg Nesterov <oleg@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 0/2] coredump: make SIGNAL_GROUP_COREDUMP more friendly to oom-killer
Date	2015-09-30 18:50 +0200
Message-ID	<qesJR-2eW-35@gated-at.bofh.it> (permalink)
References	<qe5tT-2x8-3@gated-at.bofh.it> <qeo3w-3UA-1@gated-at.bofh.it> <qeqoG-7qA-13@gated-at.bofh.it> <qesgO-1GU-31@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 10/01, Tetsuo Handa wrote:
>
> Oleg Nesterov wrote:
> > This patch just makes the SIGNAL_GROUP_COREDUMP check in task_will_free_mem()
> > a bit more correct wrt CLONE_VM tasks, nothing more.
>
> OK. Then, that's out of what I can understand. But I wish for
> some description to PATCH 2/2 about why to change from
> "do { } while_each_thread()" to "for_each_thread() { }"

while_each_thread() is deprecated, see 0c740d0afc

> because they seem to traverse differently.

Not really. And in this particular case (start from group leader)
even the order is the same, although this doesn't matter. Well,
except for_each_thread(p, t) can find no threads, but this is fine
too; this means that they all (including the leader) have exited.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/2] coredump: make SIGNAL_GROUP_COREDUMP more friendly to  oom-killer Oleg Nesterov <oleg@redhat.com> - 2015-09-29 18:00 +0200
  Re: [PATCH 0/2] coredump: make SIGNAL_GROUP_COREDUMP more friendly to oom-killer Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> - 2015-09-30 13:50 +0200
    Re: [PATCH 0/2] coredump: make SIGNAL_GROUP_COREDUMP more friendly  to oom-killer Oleg Nesterov <oleg@redhat.com> - 2015-09-30 16:20 +0200
      Re: [PATCH 0/2] coredump: make SIGNAL_GROUP_COREDUMP more friendly to oom-killer Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> - 2015-09-30 18:20 +0200
        Re: [PATCH 0/2] coredump: make SIGNAL_GROUP_COREDUMP more friendly  to oom-killer Oleg Nesterov <oleg@redhat.com> - 2015-09-30 18:50 +0200

csiph-web