Re: [PATCH 1/2] tpm, tpm_tis: use acpi_driver instead of pnp_driver

From	Matthew Garrett <mjg59@srcf.ucam.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] tpm, tpm_tis: use acpi_driver instead of pnp_driver
Date	2015-09-30 08:10 +0200
Message-ID	<qeiKv-4Sa-15@gated-at.bofh.it> (permalink)
References	<qe6zE-4i6-7@gated-at.bofh.it> <qe6zE-4i6-9@gated-at.bofh.it> <qe6T0-4Ev-5@gated-at.bofh.it> <qeiAP-4r8-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Sep 30, 2015 at 08:56:12AM +0300, Jarkko Sakkinen wrote:

> I found at least all the IDs listed from drivers/acpi/acpi_pnp.c but you
> might be right that they might be (don't know) with pnpbios.

The entries in acpi_pnp.c mean "If this device is declared in an ACPI 
table, create a PNP device". TPMs are kind of at the cutoff where some 
vendors may have shipped non-ACPI systems with TPMs that were declared 
via pnpbios, so there's a (small) risk that there are some people using 
TPMs tied to PNP devices without a corresponding ACPI device.

> Maybe a better solution would to have two tables and have only MSFT0101
> in tpm_acpi_tbl in order to make sure that old functionality is not
> broken up because we want this also to the stable kernels.

I'd agree here.

-- 
Matthew Garrett | mjg59@srcf.ucam.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH 1/2] tpm, tpm_tis: use acpi_driver instead of pnp_driver Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2015-09-29 19:10 +0200
  Re: [PATCH 1/2] tpm, tpm_tis: use acpi_driver instead of pnp_driver Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2015-09-29 19:30 +0200
    Re: [PATCH 1/2] tpm, tpm_tis: use acpi_driver instead of pnp_driver Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2015-09-30 08:00 +0200
      Re: [PATCH 1/2] tpm, tpm_tis: use acpi_driver instead of pnp_driver Matthew Garrett <mjg59@srcf.ucam.org> - 2015-09-30 08:10 +0200
  Re: [PATCH 1/2] tpm, tpm_tis: use acpi_driver instead of pnp_driver Matthew Garrett <mjg59@srcf.ucam.org> - 2015-09-29 20:10 +0200
    Re: [PATCH 1/2] tpm, tpm_tis: use acpi_driver instead of pnp_driver Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2015-09-30 08:00 +0200
      Re: [PATCH 1/2] tpm, tpm_tis: use acpi_driver instead of pnp_driver Matthew Garrett <mjg59@srcf.ucam.org> - 2015-09-30 08:10 +0200

csiph-web