Re: [PATCH 1/2] tpm, tpm_tis: use acpi_driver instead of pnp_driver

From	Matthew Garrett <mjg59@srcf.ucam.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] tpm, tpm_tis: use acpi_driver instead of pnp_driver
Date	2015-09-30 08:10 +0200
Message-ID	<qeiKu-4Sa-7@gated-at.bofh.it> (permalink)
References	<qe6zE-4i6-7@gated-at.bofh.it> <qe6zE-4i6-9@gated-at.bofh.it> <qe7vJ-5CQ-23@gated-at.bofh.it> <qeiAP-4r8-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Sep 30, 2015 at 08:58:35AM +0300, Jarkko Sakkinen wrote:
> Right. I think it would make sense to be conservative and use
> acpi_driver only for MSFT0101 because at least I don't know answer
> to this question. It would be a risk to take these fixes to the stable
> kernels othwerwise.

In that case I'd suggest just adding it to the platform driver struct 
and tidying up the init path a little (and having the platform driver 
init code request resources rather than hardcoding them). It'll make it 
easier to deal with any systems that declare TPMs in other tables such 
as Device Tree later on.

-- 
Matthew Garrett | mjg59@srcf.ucam.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] tpm, tpm_tis: use acpi_driver instead of pnp_driver Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2015-09-29 19:10 +0200
  Re: [PATCH 1/2] tpm, tpm_tis: use acpi_driver instead of pnp_driver Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2015-09-29 19:30 +0200
    Re: [PATCH 1/2] tpm, tpm_tis: use acpi_driver instead of pnp_driver Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2015-09-30 08:00 +0200
      Re: [PATCH 1/2] tpm, tpm_tis: use acpi_driver instead of pnp_driver Matthew Garrett <mjg59@srcf.ucam.org> - 2015-09-30 08:10 +0200
  Re: [PATCH 1/2] tpm, tpm_tis: use acpi_driver instead of pnp_driver Matthew Garrett <mjg59@srcf.ucam.org> - 2015-09-29 20:10 +0200
    Re: [PATCH 1/2] tpm, tpm_tis: use acpi_driver instead of pnp_driver Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2015-09-30 08:00 +0200
      Re: [PATCH 1/2] tpm, tpm_tis: use acpi_driver instead of pnp_driver Matthew Garrett <mjg59@srcf.ucam.org> - 2015-09-30 08:10 +0200

csiph-web