Re: [PATCH] tracing: use kstrdup_const instead of private implementation

From	Steven Rostedt <rostedt@goodmis.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] tracing: use kstrdup_const instead of private implementation
Date	2015-10-01 15:10 +0200
Message-ID	<qeLMv-53B-37@gated-at.bofh.it> (permalink)
References	<q6V6h-6DS-5@gated-at.bofh.it> <qevy1-6hR-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, 30 Sep 2015 21:43:00 +0200
Rasmus Villemoes <linux@rasmusvillemoes.dk> wrote:

> On Wed, Sep 09 2015, Rasmus Villemoes <linux@rasmusvillemoes.dk> wrote:
> 
> ping

Thanks for the reminder. I'll take a look at your patches today.

-- Steve

> 
> > The kernel now has kstrdup_const/kfree_const for reusing .rodata
> > (typically string literals) when possible; there's no reason to
> > duplicate that logic in the tracing system. Moreover, as the comment
> > above core_kernel_data states, it may not always return true for
> > .rodata - that is for example the case on x86_64, where we thus end up
> > kstrdup'ing all the passed-in strings.
> >
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] tracing: use kstrdup_const instead of private implementation Rasmus Villemoes <linux@rasmusvillemoes.dk> - 2015-09-30 21:50 +0200
  Re: [PATCH] tracing: use kstrdup_const instead of private  implementation Steven Rostedt <rostedt@goodmis.org> - 2015-10-01 15:10 +0200

csiph-web