Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1237421

Re: [PATCH] tracing: use kstrdup_const instead of private implementation

Path csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From Steven Rostedt <rostedt@goodmis.org>
Newsgroups linux.kernel
Subject Re: [PATCH] tracing: use kstrdup_const instead of private implementation
Date Thu, 01 Oct 2015 15:10:03 +0200
Message-ID <qeLMv-53B-37@gated-at.bofh.it> (permalink)
References <q6V6h-6DS-5@gated-at.bofh.it> <qevy1-6hR-15@gated-at.bofh.it>
X-Original-To Rasmus Villemoes <linux@rasmusvillemoes.dk>
X-Session-Marker 726F737465647440676F6F646D69732E6F7267
X-Spam-Summary 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::,RULES_HIT:41:355:379:541:599:800:960:966:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1539:1593:1594:1711:1730:1747:1777:1792:2196:2199:2393:2553:2559:2562:3138:3139:3140:3141:3142:3352:3622:3865:3867:3870:3871:3872:3874:4362:4385:5007:6261:7875:7974:10004:10400:10848:10967:11026:11232:11658:11914:12050:12517:12519:12740:13069:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0
X-He-Tag apple83_602283bf6a940
X-Filterd-Recvd-Size 1559
X-Mailer Claws Mail 3.12.0 (GTK+ 2.24.28; x86_64-pc-linux-gnu)
MIME-Version 1.0
Content-Type text/plain; charset=US-ASCII
Content-Transfer-Encoding 7bit
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 24
Organization linux.* mail to news gateway
X-Original-Cc Ingo Molnar <mingo@redhat.com>, linux-kernel@vger.kernel.org
X-Original-Date Thu, 1 Oct 2015 09:04:19 -0400
X-Original-Message-ID <20151001090419.5c5bf9b8@gandalf.local.home>
X-Original-References <1441833841-12955-1-git-send-email-linux@rasmusvillemoes.dk> <874mibg0cb.fsf@rasmusvillemoes.dk>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1237421

Show key headers only | View raw


On Wed, 30 Sep 2015 21:43:00 +0200
Rasmus Villemoes <linux@rasmusvillemoes.dk> wrote:

> On Wed, Sep 09 2015, Rasmus Villemoes <linux@rasmusvillemoes.dk> wrote:
> 
> ping

Thanks for the reminder. I'll take a look at your patches today.

-- Steve

> 
> > The kernel now has kstrdup_const/kfree_const for reusing .rodata
> > (typically string literals) when possible; there's no reason to
> > duplicate that logic in the tracing system. Moreover, as the comment
> > above core_kernel_data states, it may not always return true for
> > .rodata - that is for example the case on x86_64, where we thus end up
> > kstrdup'ing all the passed-in strings.
> >
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread


Thread

Re: [PATCH] tracing: use kstrdup_const instead of private implementation Rasmus Villemoes <linux@rasmusvillemoes.dk> - 2015-09-30 21:50 +0200
  Re: [PATCH] tracing: use kstrdup_const instead of private  implementation Steven Rostedt <rostedt@goodmis.org> - 2015-10-01 15:10 +0200

csiph-web