Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1234160

Re: [PATCH v3 2/3] powerpc/512x: add a device tree binding for LocalPlus Bus FIFO

From Timur Tabi <timur@tabi.org>
Newsgroups linux.kernel
Subject Re: [PATCH v3 2/3] powerpc/512x: add a device tree binding for LocalPlus Bus FIFO
Date 2015-09-28 15:40 +0200
Message-ID <qdGOU-Rc-39@gated-at.bofh.it> (permalink)
References <qcivg-1fu-21@gated-at.bofh.it> <qcivh-1fu-37@gated-at.bofh.it> <qcoU2-22j-7@gated-at.bofh.it> <qdGOU-Rc-37@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

Alexander Popov wrote:
> I've just followed devicetree/bindings/dma/dma.txt...
> This "rx-tx" doesn't mean much but it could show that LocalPlus Bus FIFO
> uses a single DMA read-write channel. Should I really drop it?

Hmmm, I'm not sure.  Is there anything else (besides your driver) that 
parses this device tree node?

dma.txt says this:

	"The specific strings that can be used are defined in the binding of 
the DMA client device."

So this looks like it's driver-specific, but it is a required property.
I guess you should keep it, but I think you should get a second opinion.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 0/3] powerpc/512x: add LocalPlus Bus FIFO device driver Alexander Popov <alex.popov@linux.com> - 2015-09-24 19:30 +0200
  [PATCH v3 2/3] powerpc/512x: add a device tree binding for LocalPlus Bus FIFO Alexander Popov <alex.popov@linux.com> - 2015-09-24 19:30 +0200
    Re: [PATCH v3 2/3] powerpc/512x: add a device tree binding for  LocalPlus Bus FIFO Timur Tabi <timur@tabi.org> - 2015-09-25 02:20 +0200
      Re: [PATCH v3 2/3] powerpc/512x: add a device tree binding for  LocalPlus Bus FIFO Alexander Popov <alex.popov@linux.com> - 2015-09-28 15:40 +0200
        Re: [PATCH v3 2/3] powerpc/512x: add a device tree binding for  LocalPlus Bus FIFO Timur Tabi <timur@tabi.org> - 2015-09-28 15:40 +0200
          Re: [PATCH v3 2/3] powerpc/512x: add a device tree binding for  LocalPlus Bus FIFO Alexander Popov <alex.popov@linux.com> - 2015-09-29 08:40 +0200

csiph-web