Path: csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod From: Timur Tabi Newsgroups: linux.kernel Subject: Re: [PATCH v3 2/3] powerpc/512x: add a device tree binding for LocalPlus Bus FIFO Date: Mon, 28 Sep 2015 15:40:04 +0200 Message-ID: References: X-Original-To: alex.popov@linux.com, Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Anatolij Gustschin , Gerhard Sittig , Rob Herring , Grant Likely , Dan Williams , Vinod Koul , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , linuxppc-dev@lists.ozlabs.org, dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:41.0) Gecko/20100101 Firefox/41.0 SeaMonkey/2.38 MIME-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: robomod@news.nic.it List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Approved: robomod@news.nic.it Lines: 20 Organization: linux.* mail to news gateway X-Original-Date: Mon, 28 Sep 2015 08:26:55 -0500 X-Original-Message-ID: <5609401F.3010603@tabi.org> X-Original-References: <1443115737-3948-1-git-send-email-alex.popov@linux.com> <1443115737-3948-3-git-send-email-alex.popov@linux.com> <560492C1.307@tabi.org> <56093F89.1020004@linux.com> X-Original-Sender: linux-kernel-owner@vger.kernel.org Xref: csiph.com linux.kernel:1234160 Alexander Popov wrote: > I've just followed devicetree/bindings/dma/dma.txt... > This "rx-tx" doesn't mean much but it could show that LocalPlus Bus FIFO > uses a single DMA read-write channel. Should I really drop it? Hmmm, I'm not sure. Is there anything else (besides your driver) that parses this device tree node? dma.txt says this: "The specific strings that can be used are defined in the binding of the DMA client device." So this looks like it's driver-specific, but it is a required property. I guess you should keep it, but I think you should get a second opinion. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/