Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1231018

Re: [PATCH v2 4/9] clk: rockchip: add new clock type and controller for rk3036

Show all headers | View raw

On 09/17, Xing Zheng wrote:
> +
> +static void rockchip_rk3036_pll_init(struct clk_hw *hw)

init ops are "discouraged". Could we do this through assigned
rates instead?

> +{
> +	struct rockchip_clk_pll *pll = to_rockchip_clk_pll(hw);
> +	const struct rockchip_pll_rate_table *rate;
> +	unsigned int fbdiv, postdiv1, refdiv, postdiv2, dsmpd, frac;
> +	unsigned long drate;
> +	u32 pllcon;
> +
> +	if (!(pll->flags & ROCKCHIP_PLL_SYNC_RATE))
> +		return;

I don't understand what this one does though. This check isn't in
the set rate ops.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 4/9] clk: rockchip: add new clock type and controller  for rk3036 Stephen Boyd <sboyd@codeaurora.org> - 2015-09-23 00:50 +0200
  Re: [PATCH v2 4/9] clk: rockchip: add new clock type and controller for rk3036 Heiko Stübner <heiko@sntech.de> - 2015-09-23 01:00 +0200
    Re: [PATCH v2 4/9] clk: rockchip: add new clock type and controller  for rk3036 Stephen Boyd <sboyd@codeaurora.org> - 2015-09-23 01:20 +0200
      Re: [PATCH v2 4/9] clk: rockchip: add new clock type and controller for rk3036 Heiko Stübner <heiko@sntech.de> - 2015-10-01 01:40 +0200
        Re: [PATCH v2 4/9] clk: rockchip: add new clock type and controller  for rk3036 Stephen Boyd <sboyd@codeaurora.org> - 2015-10-01 03:00 +0200

csiph-web