Re: [PATCH v2 4/9] clk: rockchip: add new clock type and controller for rk3036

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Stephen Boyd <sboyd@codeaurora.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 4/9] clk: rockchip: add new clock type and controller for rk3036
Date	Wed, 23 Sep 2015 00:50:01 +0200
Message-ID	<qbExP-2ia-7@gated-at.bofh.it> (permalink)
References	<q9CTv-6sU-5@gated-at.bofh.it> <q9CTv-6sU-3@gated-at.bofh.it>
X-Original-To	Xing Zheng <zhengxing@rock-chips.com>
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.21 (2010-09-15)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	28
Organization	linux.* mail to news gateway
X-Original-Cc	heiko@sntech.de, linux-rockchip@lists.infradead.org, Michael Turquette <mturquette@baylibre.com>, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
X-Original-Date	Tue, 22 Sep 2015 15:41:25 -0700
X-Original-Message-ID	<20150922224125.GK23081@codeaurora.org>
X-Original-References	<1442478540-15068-1-git-send-email-zhengxing@rock-chips.com> <1442478540-15068-5-git-send-email-zhengxing@rock-chips.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1231018

Show key headers only | View raw

On 09/17, Xing Zheng wrote:
> +
> +static void rockchip_rk3036_pll_init(struct clk_hw *hw)

init ops are "discouraged". Could we do this through assigned
rates instead?

> +{
> +	struct rockchip_clk_pll *pll = to_rockchip_clk_pll(hw);
> +	const struct rockchip_pll_rate_table *rate;
> +	unsigned int fbdiv, postdiv1, refdiv, postdiv2, dsmpd, frac;
> +	unsigned long drate;
> +	u32 pllcon;
> +
> +	if (!(pll->flags & ROCKCHIP_PLL_SYNC_RATE))
> +		return;

I don't understand what this one does though. This check isn't in
the set rate ops.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 4/9] clk: rockchip: add new clock type and controller  for rk3036 Stephen Boyd <sboyd@codeaurora.org> - 2015-09-23 00:50 +0200
  Re: [PATCH v2 4/9] clk: rockchip: add new clock type and controller for rk3036 Heiko Stübner <heiko@sntech.de> - 2015-09-23 01:00 +0200
    Re: [PATCH v2 4/9] clk: rockchip: add new clock type and controller  for rk3036 Stephen Boyd <sboyd@codeaurora.org> - 2015-09-23 01:20 +0200
      Re: [PATCH v2 4/9] clk: rockchip: add new clock type and controller for rk3036 Heiko Stübner <heiko@sntech.de> - 2015-10-01 01:40 +0200
        Re: [PATCH v2 4/9] clk: rockchip: add new clock type and controller  for rk3036 Stephen Boyd <sboyd@codeaurora.org> - 2015-10-01 03:00 +0200

csiph-web