Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1228797

Re: [PATCH 2/3] ASoC: da7219: Add bindings documentation for DA7219 audio codec

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Thu, Sep 17, 2015 at 05:01:16PM +0100, Adam Thomson wrote:

> +- dlg,io-lvl : Expected voltage level range for digital IO
> +	["2.5V_3.6V", "1.2V_2.8V"]

If the driver needs to read or set the voltage a supply is at it should
do that via the regulator API.

> +- dlg,cp-mchange : Charge pump voltage tracking mode
> +	["largest_vol", "dac_vol", "sig_mag"]
> +- dlg,cp-vol-thresh : Charge pump volume threshold value (6-bit value)
> +	[ 0 - 0x3F ]

Why are these in the device tree rather than runtime parameters?

> +Child node - 'da7219_aad':
> +
> +Required properties:
> +- interrupt-parent : Specifies the phandle of the interrupt controller to which
> +  the IRQs from DA7219 AAD block are delivered to.
> +- interrupts : IRQ line info for DA7219 AAD block.
> +  (See Documentation/devicetree/bindings/interrupt-controller/interrupts.txt for
> +   further information relating to interrupt properties)

Why is this not specified at the device level (the device does not
appear to support other interrupts)?

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 2/3] ASoC: da7219: Add bindings documentation for DA7219 audio  codec Adam Thomson <Adam.Thomson.Opensource@diasemi.com> - 2015-09-17 18:10 +0200
  Re: [PATCH 2/3] ASoC: da7219: Add bindings documentation for DA7219  audio codec Mark Brown <broonie@kernel.org> - 2015-09-20 02:40 +0200
    RE: [PATCH 2/3] ASoC: da7219: Add bindings documentation for DA7219  audio codec "Opensource [Adam Thomson]" <Adam.Thomson.Opensource@diasemi.com> - 2015-09-21 12:40 +0200
      Re: [PATCH 2/3] ASoC: da7219: Add bindings documentation for DA7219  audio codec Mark Brown <broonie@kernel.org> - 2015-09-21 18:50 +0200

csiph-web