Re: [PATCH 2/3] ASoC: da7219: Add bindings documentation for DA7219 audio codec

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Mark Brown <broonie@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/3] ASoC: da7219: Add bindings documentation for DA7219 audio codec
Date	Sun, 20 Sep 2015 02:40:02 +0200
Message-ID	<qaAPE-JA-17@gated-at.bofh.it> (permalink)
References	<q9JV0-bo-19@gated-at.bofh.it> <q9JV1-bo-59@gated-at.bofh.it>
X-Original-To	Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
MIME-Version	1.0
Content-Type	multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="tSiBuZsJmMXpnp7T"
Content-Disposition	inline
X-Cookie	NOBODY EXPECTS THE SPANISH INQUISITION!
User-Agent	Mutt/1.5.23 (2014-03-12)
X-Sa-Exim-Connect-IP	209.49.225.226
X-Sa-Exim-Mail-From	broonie@sirena.org.uk
X-Sa-Exim-Version	4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000)
X-Sa-Exim-Scanned	Yes (on mezzanine.sirena.org.uk)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	54
Organization	linux.* mail to news gateway
X-Original-Cc	Liam Girdwood <lgirdwood@gmail.com>, Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>, Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>, Mark Rutland <mark.rutland@arm.com>, Ian Campbell <ijc+devicetree@hellion.org.uk>, Kumar Gala <galak@codeaurora.org>, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Support Opensource <support.opensource@diasemi.com>, Jason Coughlan <jason.coughlan@diasemi.com>
X-Original-Date	Sat, 19 Sep 2015 10:10:17 -0700
X-Original-Message-ID	<20150919171017.GI30445@sirena.org.uk>
X-Original-References	<cover.1442500784.git.Adam.Thomson.Opensource@diasemi.com> <381b367e0a4c6c9e00db74f1b0e91d383156ba86.1442500784.git.Adam.Thomson.Opensource@diasemi.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1228797

Show key headers only | View raw

[Multipart message — attachments visible in raw view] - view raw

On Thu, Sep 17, 2015 at 05:01:16PM +0100, Adam Thomson wrote:

> +- dlg,io-lvl : Expected voltage level range for digital IO
> +	["2.5V_3.6V", "1.2V_2.8V"]

If the driver needs to read or set the voltage a supply is at it should
do that via the regulator API.

> +- dlg,cp-mchange : Charge pump voltage tracking mode
> +	["largest_vol", "dac_vol", "sig_mag"]
> +- dlg,cp-vol-thresh : Charge pump volume threshold value (6-bit value)
> +	[ 0 - 0x3F ]

Why are these in the device tree rather than runtime parameters?

> +Child node - 'da7219_aad':
> +
> +Required properties:
> +- interrupt-parent : Specifies the phandle of the interrupt controller to which
> +  the IRQs from DA7219 AAD block are delivered to.
> +- interrupts : IRQ line info for DA7219 AAD block.
> +  (See Documentation/devicetree/bindings/interrupt-controller/interrupts.txt for
> +   further information relating to interrupt properties)

Why is this not specified at the device level (the device does not
appear to support other interrupts)?

Thread

[PATCH 2/3] ASoC: da7219: Add bindings documentation for DA7219 audio  codec Adam Thomson <Adam.Thomson.Opensource@diasemi.com> - 2015-09-17 18:10 +0200
  Re: [PATCH 2/3] ASoC: da7219: Add bindings documentation for DA7219  audio codec Mark Brown <broonie@kernel.org> - 2015-09-20 02:40 +0200
    RE: [PATCH 2/3] ASoC: da7219: Add bindings documentation for DA7219  audio codec "Opensource [Adam Thomson]" <Adam.Thomson.Opensource@diasemi.com> - 2015-09-21 12:40 +0200
      Re: [PATCH 2/3] ASoC: da7219: Add bindings documentation for DA7219  audio codec Mark Brown <broonie@kernel.org> - 2015-09-21 18:50 +0200

csiph-web