Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1327620

Re: [PATCH] mm/hugetlb: fix gigantic page initialization/allocation

Show all headers | View raw

On 02/03/2016 05:15 AM, Mike Kravetz wrote:
> On 02/02/2016 07:01 PM, Naoya Horiguchi wrote:
>> On Tue, Feb 02, 2016 at 03:17:10PM -0800, Mike Kravetz wrote:
>>> I agree.  Naoya did debug and provide fix via e-mail exchange.  He did not
>>> sign-off and I could not tell if he was going to pursue.  My only intention
>>> was to fix ASAP.
>>>
>>> More than happy to give Naoya credit.
>>
>> Thank you! It's great if you append my signed-off below yours.
>>
>> Naoya
> 
> Adding Naoya's sign off and Acks received
> 
> mm/hugetlb: fix gigantic page initialization/allocation
> 
> Attempting to preallocate 1G gigantic huge pages at boot time with
> "hugepagesz=1G hugepages=1" on the kernel command line will prevent
> booting with the following:
> 
> kernel BUG at mm/hugetlb.c:1218!
> 
> When mapcount accounting was reworked, the setting of compound_mapcount_ptr
> in prep_compound_gigantic_page was overlooked.  As a result, the validation
> of mapcount in free_huge_page fails.
> 
> The "BUG_ON" checks in free_huge_page were also changed to "VM_BUG_ON_PAGE"
> to assist with debugging.
> 
> Fixes: af5642a8af ("mm: rework mapcount accounting to enable 4k mapping
> of THPs")
> Signed-off-by: Mike Kravetz <mike.kravetz@oracle.com>
> Signed-off-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
> Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> Acked-by: David Rientjes <rientjes@google.com>

Tested-by: Vlastimil Babka <vbabka@suse.cz>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] mm/hugetlb: fix gigantic page initialization/allocation Mike Kravetz <mike.kravetz@oracle.com> - 2016-02-02 23:40 +0100
  Re: [PATCH] mm/hugetlb: fix gigantic page  initialization/allocation David Rientjes <rientjes@google.com> - 2016-02-03 00:00 +0100
    Re: [PATCH] mm/hugetlb: fix gigantic page initialization/allocation Mike Kravetz <mike.kravetz@oracle.com> - 2016-02-03 00:20 +0100
      Re: [PATCH] mm/hugetlb: fix gigantic page initialization/allocation Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> - 2016-02-03 04:10 +0100
        Re: [PATCH] mm/hugetlb: fix gigantic page initialization/allocation Mike Kravetz <mike.kravetz@oracle.com> - 2016-02-03 05:20 +0100
          Re: [PATCH] mm/hugetlb: fix gigantic page initialization/allocation Vlastimil Babka <vbabka@suse.cz> - 2016-02-05 13:00 +0100
  Re: [PATCH] mm/hugetlb: fix gigantic page initialization/allocation "Kirill A. Shutemov" <kirill@shutemov.name> - 2016-02-03 00:00 +0100

csiph-web