Re: [PATCH] mm/hugetlb: fix gigantic page initialization/allocation

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Vlastimil Babka <vbabka@suse.cz>
Newsgroups	linux.kernel
Subject	Re: [PATCH] mm/hugetlb: fix gigantic page initialization/allocation
Date	Fri, 05 Feb 2016 13:00:02 +0100
Message-ID	<qYNdo-85k-25@gated-at.bofh.it> (permalink)
References	<qXRM5-1qu-1@gated-at.bofh.it> <qXS5r-1xR-3@gated-at.bofh.it> <qXSoP-1XH-23@gated-at.bofh.it> <qXVZo-4BL-11@gated-at.bofh.it> <qXX58-5ma-25@gated-at.bofh.it>
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0
MIME-Version	1.0
Content-Type	text/plain; charset=iso-2022-jp
Content-Transfer-Encoding	7bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	38
Organization	linux.* mail to news gateway
X-Original-Cc	David Rientjes <rientjes@google.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-mm@kvack.org" <linux-mm@kvack.org>, "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>, "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>, Jerome Marchand <jmarchan@redhat.com>, Michal Hocko <mhocko@suse.cz>
X-Original-Date	Fri, 5 Feb 2016 12:52:17 +0100
X-Original-Message-ID	<56B48CF1.1040103@suse.cz>
X-Original-References	<1454452420-25007-1-git-send-email-mike.kravetz@oracle.com> <alpine.DEB.2.10.1602021457500.9118@chino.kir.corp.google.com> <56B138F6.70704@oracle.com> <20160203030137.GA22446@hori1.linux.bs1.fc.nec.co.jp> <56B17ED2.2070205@oracle.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1327620

Show key headers only | View raw

On 02/03/2016 05:15 AM, Mike Kravetz wrote:
> On 02/02/2016 07:01 PM, Naoya Horiguchi wrote:
>> On Tue, Feb 02, 2016 at 03:17:10PM -0800, Mike Kravetz wrote:
>>> I agree.  Naoya did debug and provide fix via e-mail exchange.  He did not
>>> sign-off and I could not tell if he was going to pursue.  My only intention
>>> was to fix ASAP.
>>>
>>> More than happy to give Naoya credit.
>>
>> Thank you! It's great if you append my signed-off below yours.
>>
>> Naoya
> 
> Adding Naoya's sign off and Acks received
> 
> mm/hugetlb: fix gigantic page initialization/allocation
> 
> Attempting to preallocate 1G gigantic huge pages at boot time with
> "hugepagesz=1G hugepages=1" on the kernel command line will prevent
> booting with the following:
> 
> kernel BUG at mm/hugetlb.c:1218!
> 
> When mapcount accounting was reworked, the setting of compound_mapcount_ptr
> in prep_compound_gigantic_page was overlooked.  As a result, the validation
> of mapcount in free_huge_page fails.
> 
> The "BUG_ON" checks in free_huge_page were also changed to "VM_BUG_ON_PAGE"
> to assist with debugging.
> 
> Fixes: af5642a8af ("mm: rework mapcount accounting to enable 4k mapping
> of THPs")
> Signed-off-by: Mike Kravetz <mike.kravetz@oracle.com>
> Signed-off-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
> Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> Acked-by: David Rientjes <rientjes@google.com>

Tested-by: Vlastimil Babka <vbabka@suse.cz>

Thread

[PATCH] mm/hugetlb: fix gigantic page initialization/allocation Mike Kravetz <mike.kravetz@oracle.com> - 2016-02-02 23:40 +0100
  Re: [PATCH] mm/hugetlb: fix gigantic page  initialization/allocation David Rientjes <rientjes@google.com> - 2016-02-03 00:00 +0100
    Re: [PATCH] mm/hugetlb: fix gigantic page initialization/allocation Mike Kravetz <mike.kravetz@oracle.com> - 2016-02-03 00:20 +0100
      Re: [PATCH] mm/hugetlb: fix gigantic page initialization/allocation Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> - 2016-02-03 04:10 +0100
        Re: [PATCH] mm/hugetlb: fix gigantic page initialization/allocation Mike Kravetz <mike.kravetz@oracle.com> - 2016-02-03 05:20 +0100
          Re: [PATCH] mm/hugetlb: fix gigantic page initialization/allocation Vlastimil Babka <vbabka@suse.cz> - 2016-02-05 13:00 +0100
  Re: [PATCH] mm/hugetlb: fix gigantic page initialization/allocation "Kirill A. Shutemov" <kirill@shutemov.name> - 2016-02-03 00:00 +0100

csiph-web