Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1325163
| From | Krzysztof Kozlowski <k.kozlowski@samsung.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH V2 4/5] mfd: max77686: do not set i2c client data for rtc i2c client |
| Date | 2016-02-03 11:30 +0100 |
| Message-ID | <qY2Rd-H6-29@gated-at.bofh.it> (permalink) |
| References | <qY2eu-ew-3@gated-at.bofh.it> <qY2eu-ew-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 03.02.2016 18:30, Laxman Dewangan wrote: > There is different RTC I2C address for RTC block in MAX77686. > Driver is creating dummy i2c client for this address to access > the register of this IP block. > > As there is no need to get any data from this rtc i2c client, > it is not required to set client data for this i2c client. > > Suggested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> > Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com> > CC: Krzysztof Kozlowski <k.kozlowski@samsung.com> > CC: Javier Martinez Canillas <javier@osg.samsung.com> > > --- > This is new in this series based on review comment from V1. > You could trim a little bit the description - "stored pointer is not retrieved anywhere, there is no call to i2c_get_clientdata()" might be sufficient but anyway: Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> Best regards, Krzysztof
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH V2 4/5] mfd: max77686: do not set i2c client data for rtc i2c client Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-03 10:50 +0100 Re: [PATCH V2 4/5] mfd: max77686: do not set i2c client data for rtc i2c client Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-02-03 11:30 +0100 Re: [PATCH V2 4/5] mfd: max77686: do not set i2c client data for rtc i2c client Javier Martinez Canillas <javier@osg.samsung.com> - 2016-02-03 13:50 +0100
csiph-web