[PATCH V2 4/5] mfd: max77686: do not set i2c client data for rtc i2c client

From	Laxman Dewangan <ldewangan@nvidia.com>
Newsgroups	linux.kernel
Subject	[PATCH V2 4/5] mfd: max77686: do not set i2c client data for rtc i2c client
Date	2016-02-03 10:50 +0100
Message-ID	<qY2eu-ew-1@gated-at.bofh.it> (permalink)
References	<qY2eu-ew-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

There is different RTC I2C address for RTC block in MAX77686.
Driver is creating dummy i2c client for this address to access
the register of this IP block.

As there is no need to get any data from this rtc i2c client,
it is not required to set client data for this i2c client.

Suggested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
CC: Krzysztof Kozlowski <k.kozlowski@samsung.com>
CC: Javier Martinez Canillas <javier@osg.samsung.com>

---
This is new in this series based on review comment from V1.

 drivers/mfd/max77686.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/mfd/max77686.c b/drivers/mfd/max77686.c
index d959ebb..bda6fd7 100644
--- a/drivers/mfd/max77686.c
+++ b/drivers/mfd/max77686.c
@@ -277,7 +277,6 @@ static int max77686_i2c_probe(struct i2c_client *i2c,
 				"Failed to allocate I2C device for RTC\n");
 			return -ENODEV;
 		}
-		i2c_set_clientdata(max77686->rtc, max77686);
 
 		max77686->rtc_regmap =
 			devm_regmap_init_i2c(max77686->rtc,
-- 
2.1.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH V2 4/5] mfd: max77686: do not set i2c client data for rtc i2c client Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-03 10:50 +0100
  Re: [PATCH V2 4/5] mfd: max77686: do not set i2c client data for rtc  i2c client Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-02-03 11:30 +0100
  Re: [PATCH V2 4/5] mfd: max77686: do not set i2c client data for rtc  i2c client Javier Martinez Canillas <javier@osg.samsung.com> - 2016-02-03 13:50 +0100

csiph-web