Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1321134

Re: [PATCH V4 2/2] regulator: mt6323: Add support for MT6323 regulator

From Mark Brown <broonie@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH V4 2/2] regulator: mt6323: Add support for MT6323 regulator
Date 2016-01-29 00:20 +0100
Message-ID <qW414-2cO-13@gated-at.bofh.it> (permalink)
References <qVx59-3fC-15@gated-at.bofh.it> <qVx59-3fC-13@gated-at.bofh.it> <qVzzY-4VL-9@gated-at.bofh.it> <qVZkK-7kv-17@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


[Multipart message — attachments visible in raw view] - view raw

On Thu, Jan 28, 2016 at 07:13:48PM +0100, John Crispin wrote:

> would the following two bindings be ok ? I would create patches to add them.

> * regulator-allow-mode; or regulator-allow-change-mode;

This seems redundant, if we have a list of valid modes presumably they
can be used - same idea as with voltage setting.

> * regulator-modes = <REGULATOR_MODE_NORMAL REGULATOR_MODE_STANDBY>;

I'm not convinced this binding makes sense, how would a user of the API
(currently there are none in tree) know what the modes mean?  It's a bit
different when the user is supplying configuration for a specific
regulator but this needs to be something that can be used by consumers.

What are you actually trying to do with this?

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [PATCH V4 2/2] regulator: mt6323: Add support for MT6323  regulator John Crispin <blogic@openwrt.org> - 2016-01-28 19:20 +0100
  Re: [PATCH V4 2/2] regulator: mt6323: Add support for MT6323  regulator Mark Brown <broonie@kernel.org> - 2016-01-29 00:20 +0100
    Re: [PATCH V4 2/2] regulator: mt6323: Add support for MT6323  regulator menghui lin <menghui.lin@mediatek.com> - 2016-01-29 11:00 +0100
      Re: [PATCH V4 2/2] regulator: mt6323: Add support for MT6323  regulator Mark Brown <broonie@kernel.org> - 2016-01-29 12:30 +0100
        Re: [PATCH V4 2/2] regulator: mt6323: Add support for MT6323  regulator menghui lin <menghui.lin@mediatek.com> - 2016-01-29 13:20 +0100
          Re: [PATCH V4 2/2] regulator: mt6323: Add support for MT6323  regulator Mark Brown <broonie@kernel.org> - 2016-02-02 20:40 +0100
          Re: [PATCH V4 2/2] regulator: mt6323: Add support for MT6323  regulator Mark Brown <broonie@kernel.org> - 2016-02-02 20:40 +0100
            Re: [PATCH V4 2/2] regulator: mt6323: Add support for MT6323  regulator menghui lin <menghui.lin@mediatek.com> - 2016-02-03 06:40 +0100
              Re: [PATCH V4 2/2] regulator: mt6323: Add support for MT6323  regulator Mark Brown <broonie@kernel.org> - 2016-02-03 13:40 +0100
                Re: [PATCH V4 2/2] regulator: mt6323: Add support for MT6323  regulator menghui lin <menghui.lin@mediatek.com> - 2016-02-04 03:50 +0100

csiph-web