Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1316216

Re: [PATCH v6 4/5] cpufreq: powernv: Replace pr_info with trace print for throttle event

Show all headers | View raw

On 22-01-16, 12:49, Shilpasri G Bhat wrote:
> Currently we use printk message to notify the throttle event. But this
> can flood the console if the cpu is throttled frequently. So replace the
> printk with the tracepoint to notify the throttle event. And also events
> like throttle below nominal frequency and OCC_RESET are reduced to
> pr_warn/pr_warn_once as pointed by MFG to not mark them as critical
> messages. This patch adds 'throt_reason' to struct chip to store the
> throttle reason.
> 
> Signed-off-by: Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com>
> Reviewed-by: Gautham R. Shenoy <ego@linux.vnet.ibm.com>
> ---
> No changes from v5.

You have done too many things in a single patch, its always better to
keep a patch for a special problem. Don't try to solve everything in
the same patch.

Though, I am NOT strongly saying that you respin this patch now.

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

-- 
viresh

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v6 0/5] cpufreq: powernv: Redesign the presentation of throttle notification and solve bug-fixes in the driver Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com> - 2016-01-22 08:30 +0100
  [PATCH v6 5/5] cpufreq: powernv: Add sysfs attributes to show throttle stats Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com> - 2016-01-22 08:30 +0100
    Re: [PATCH v6 5/5] cpufreq: powernv: Add sysfs attributes to show  throttle stats Balbir Singh <bsingharora@gmail.com> - 2016-01-23 09:50 +0100
      Re: [PATCH v6 5/5] cpufreq: powernv: Add sysfs attributes to show  throttle stats Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com> - 2016-01-25 07:50 +0100
    Re: [v6, 5/5] cpufreq: powernv: Add sysfs attributes to show throttle stats Michael Ellerman <mpe@ellerman.id.au> - 2016-01-25 06:50 +0100
  [PATCH v6 3/5] cpufreq: powernv/tracing: Add powernv_throttle tracepoint Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com> - 2016-01-22 08:30 +0100
  [PATCH v6 1/5] cpufreq: powernv: Hot-plug safe the kworker thread Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com> - 2016-01-22 08:30 +0100
    Re: [PATCH v6 1/5] cpufreq: powernv: Hot-plug safe the kworker thread Viresh Kumar <viresh.kumar@linaro.org> - 2016-01-25 06:50 +0100
  [PATCH v6 2/5] cpufreq: powernv: Remove cpu_to_chip_id() from hot-path Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com> - 2016-01-22 08:30 +0100
    Re: [PATCH v6 2/5] cpufreq: powernv: Remove cpu_to_chip_id() from  hot-path Balbir Singh <bsingharora@gmail.com> - 2016-01-23 10:00 +0100
      Re: [PATCH v6 2/5] cpufreq: powernv: Remove cpu_to_chip_id() from  hot-path Gautham R Shenoy <ego@linux.vnet.ibm.com> - 2016-01-25 06:40 +0100
    Re: [PATCH v6 2/5] cpufreq: powernv: Remove cpu_to_chip_id() from  hot-path Viresh Kumar <viresh.kumar@linaro.org> - 2016-01-25 07:00 +0100
  [PATCH v6 4/5] cpufreq: powernv: Replace pr_info with trace print for throttle event Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com> - 2016-01-22 08:30 +0100
    Re: [PATCH v6 4/5] cpufreq: powernv: Replace pr_info with trace  print for throttle event Viresh Kumar <viresh.kumar@linaro.org> - 2016-01-25 07:00 +0100

csiph-web