Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1314791

[PATCH v6 0/5] cpufreq: powernv: Redesign the presentation of throttle notification and solve bug-fixes in the driver

Show all headers | View raw

In POWER8, OCC(On-Chip-Controller) can throttle the frequency of the
CPU when the chip crosses its thermal and power limits. Currently,
powernv-cpufreq driver detects and reports this event as a console
message. Some machines may not sustain the max turbo frequency in all
conditions and can be throttled frequently. This can lead to the
flooding of console with throttle messages. So this patchset aims to
redesign the presentation of this event via sysfs counters and
tracepoints. And it also fixes couple of bugs reported in the driver.

- Patch [1] fixes the cpu hot-plug bug in powernv_cpufreq_work_fn().
- Patch [2] solves a bug in powernv_cpufreq_throttle_check(), which
  calls in to cpu_to_chip_id() in hot path which reads DT every time
  to find the chip id.
- Patches [3] to [5] will add a perf trace point
  "power:powernv_throttle" and sysfs throttle counter stats in
  /sys/devices/system/cpu/cpufreq/chipN.

Changes from v5:
- Fix kbuild error:
drivers/cpufreq/powernv-cpufreq.c:428:2: error: implicit declaration of
function 'get_online_cpus' [-Werror=implicit-function-declaration]

Changes from v4:
- Fix a hot-plug bug in powernv_cpufreq_work_fn()
- Changes wrt Gautham's and Shreyas's comments 

Changes from v3:
- Add a fix to replace cpu_to_chip_id() with simpler PIR shift to 
  obtain the chip id.
- Break patch2 in to two patches separating the tracepoint and sysfs
  attribute changes.

Changes from v2:
- Fixed kbuild test warning.
drivers/cpufreq/powernv-cpufreq.c:609:2: warning: ignoring return
value of 'kstrtoint', declared with attribute warn_unused_result
[-Wunused-result]

Shilpasri G Bhat (5):
  cpufreq: powernv: Hot-plug safe the kworker thread
  cpufreq: powernv: Remove cpu_to_chip_id() from hot-path
  cpufreq: powernv/tracing: Add powernv_throttle tracepoint
  cpufreq: powernv: Replace pr_info with trace print for throttle event
  cpufreq: powernv: Add sysfs attributes to show throttle stats

 drivers/cpufreq/powernv-cpufreq.c | 313 +++++++++++++++++++++++++++++++-------
 include/trace/events/power.h      |  22 +++
 kernel/trace/power-traces.c       |   1 +
 3 files changed, 281 insertions(+), 55 deletions(-)

-- 
1.9.3

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH v6 0/5] cpufreq: powernv: Redesign the presentation of throttle notification and solve bug-fixes in the driver Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com> - 2016-01-22 08:30 +0100
  [PATCH v6 5/5] cpufreq: powernv: Add sysfs attributes to show throttle stats Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com> - 2016-01-22 08:30 +0100
    Re: [PATCH v6 5/5] cpufreq: powernv: Add sysfs attributes to show  throttle stats Balbir Singh <bsingharora@gmail.com> - 2016-01-23 09:50 +0100
      Re: [PATCH v6 5/5] cpufreq: powernv: Add sysfs attributes to show  throttle stats Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com> - 2016-01-25 07:50 +0100
    Re: [v6, 5/5] cpufreq: powernv: Add sysfs attributes to show throttle stats Michael Ellerman <mpe@ellerman.id.au> - 2016-01-25 06:50 +0100
  [PATCH v6 3/5] cpufreq: powernv/tracing: Add powernv_throttle tracepoint Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com> - 2016-01-22 08:30 +0100
  [PATCH v6 1/5] cpufreq: powernv: Hot-plug safe the kworker thread Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com> - 2016-01-22 08:30 +0100
    Re: [PATCH v6 1/5] cpufreq: powernv: Hot-plug safe the kworker thread Viresh Kumar <viresh.kumar@linaro.org> - 2016-01-25 06:50 +0100
  [PATCH v6 2/5] cpufreq: powernv: Remove cpu_to_chip_id() from hot-path Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com> - 2016-01-22 08:30 +0100
    Re: [PATCH v6 2/5] cpufreq: powernv: Remove cpu_to_chip_id() from  hot-path Balbir Singh <bsingharora@gmail.com> - 2016-01-23 10:00 +0100
      Re: [PATCH v6 2/5] cpufreq: powernv: Remove cpu_to_chip_id() from  hot-path Gautham R Shenoy <ego@linux.vnet.ibm.com> - 2016-01-25 06:40 +0100
    Re: [PATCH v6 2/5] cpufreq: powernv: Remove cpu_to_chip_id() from  hot-path Viresh Kumar <viresh.kumar@linaro.org> - 2016-01-25 07:00 +0100
  [PATCH v6 4/5] cpufreq: powernv: Replace pr_info with trace print for throttle event Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com> - 2016-01-22 08:30 +0100
    Re: [PATCH v6 4/5] cpufreq: powernv: Replace pr_info with trace  print for throttle event Viresh Kumar <viresh.kumar@linaro.org> - 2016-01-25 07:00 +0100

csiph-web