Groups > linux.kernel > #1312028

Re: [PATCH v2 05/10] tty: Fix tty_init_termios() declaration

From	Johan Hovold <johan@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 05/10] tty: Fix tty_init_termios() declaration
Date	2016-01-19 10:20 +0100
Message-ID	<qSACd-5IF-1@gated-at.bofh.it> (permalink)
References	<qzDqV-2GJ-3@gated-at.bofh.it> <qPgA1-87H-1@gated-at.bofh.it> <qPgA1-87H-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat, Jan 09, 2016 at 09:13:48PM -0800, Peter Hurley wrote:
> tty_init_termios() never returns an error; re-declare as void. Remove
> unnecessary error handling from callers. Remove extern declarations
> of tty_free_termios() and free_tty_struct() and re-declare in file
> scope.
> 
> Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
> ---
>  drivers/tty/pty.c            | 15 +++------------
>  drivers/tty/tty_io.c         | 13 ++++---------
>  drivers/usb/serial/console.c |  6 +-----

For the usb-serial bits

Acked-by: Johan Hovold <johan@kernel.org>

Thanks,
Johan

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v2 05/10] tty: Fix tty_init_termios() declaration Johan Hovold <johan@kernel.org> - 2016-01-19 10:20 +0100

csiph-web