Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1312028
| Path | csiph.com!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Johan Hovold <johan@kernel.org> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 05/10] tty: Fix tty_init_termios() declaration |
| Date | Tue, 19 Jan 2016 10:20:01 +0100 |
| Message-ID | <qSACd-5IF-1@gated-at.bofh.it> (permalink) |
| References | <qzDqV-2GJ-3@gated-at.bofh.it> <qPgA1-87H-1@gated-at.bofh.it> <qPgA1-87H-7@gated-at.bofh.it> |
| X-Original-To | Peter Hurley <peter@hurleysoftware.com> |
| Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=OaDQfYb/YcG2E7KoLHUB9WaKr3IRXL9xfCuKOmNIQ+g=; b=TPuYpIlux5El4UeifttK6reDOBJ1EQ8txGyytG8oMaM4G+S2A0OTmgs4w9cUkJMhIw 7tWki2UEExTHRkzAHAsgr+hr/c2hjWgS42uNlVJ909YGePXzGui0/g3De7T+d4KUaby9 PfauCfBrnMoX7r6FBwPZ3VdLJjDEq7JeZZKsj0U+8XI9A34S1AJSB/K2jyIZcAnn6C/n VLh3ntEbYvKNj064QzjFcZmCe4FPiThttFewvR35tmRgGKkKE7nAB80jWiDUFb6Egw17 CzjEpU5pHf2D+/cxBfYtHlxDt1eGpu6bwmxt63nD9n3l/gkQBPVxVpRF0Est2L0JbU1X ZdDg== |
| X-Google-Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-type:content-disposition :in-reply-to:user-agent; bh=OaDQfYb/YcG2E7KoLHUB9WaKr3IRXL9xfCuKOmNIQ+g=; b=dl8702TAe8t7LKfmhKJaH+Iys1gFWTOY9y0PLrdfFue/KpCVexIuvc9SA/QwwnJboF gpRZiW5lZlr20Bd6AXke2+LvZUd8er2uFs4BdAAXl5hVI629CpVaH+pZw+PeIwUc8XYJ OKZ2xX9bEH+74v0XQgDBUeP6rg55sTqVnj6tLlzw6ER8pArSUD4k7tDUvnMxNXKtuVCf DOMrkgm1p4lDX6bc63/ZGJvOrJN3xL5m+GHUXzkLoe2u2IjR5e8sXBJ9CHCH4nN+Zh2p /VO1MMWQs5ue8YLBOYYOL4N/bJhFFX45hXzgij+NGcL4b3IdQLma+BZn0iYaliScNGMj ojiQ== |
| X-Gm-Message-State | ALoCoQn+JiaLDBFyf+DpzJFJP+l191KrLzyE2zHOmLu20ED9qHWdPz14/YHdg+5/AF4unehGwsxtqtXWS2PsVvOAjABReHch4g== |
| X-Received | by 10.112.149.2 with SMTP id tw2mr10359814lbb.75.1453195023497; Tue, 19 Jan 2016 01:17:03 -0800 (PST) |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=us-ascii |
| Content-Disposition | inline |
| User-Agent | Mutt/1.5.23 (2014-03-12) |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 18 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Jiri Slaby <jslaby@suse.cz>, linux-kernel@vger.kernel.org |
| X-Original-Date | Tue, 19 Jan 2016 10:17:02 +0100 |
| X-Original-Message-ID | <20160119091702.GA28220@localhost> |
| X-Original-References | <1448677557-16420-1-git-send-email-peter@hurleysoftware.com> <1452402833-8652-1-git-send-email-peter@hurleysoftware.com> <1452402833-8652-6-git-send-email-peter@hurleysoftware.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1312028 |
Show key headers only | View raw
On Sat, Jan 09, 2016 at 09:13:48PM -0800, Peter Hurley wrote: > tty_init_termios() never returns an error; re-declare as void. Remove > unnecessary error handling from callers. Remove extern declarations > of tty_free_termios() and free_tty_struct() and re-declare in file > scope. > > Signed-off-by: Peter Hurley <peter@hurleysoftware.com> > --- > drivers/tty/pty.c | 15 +++------------ > drivers/tty/tty_io.c | 13 ++++--------- > drivers/usb/serial/console.c | 6 +----- For the usb-serial bits Acked-by: Johan Hovold <johan@kernel.org> Thanks, Johan
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
Re: [PATCH v2 05/10] tty: Fix tty_init_termios() declaration Johan Hovold <johan@kernel.org> - 2016-01-19 10:20 +0100
csiph-web