[PATCH 2/2] bfin_mac: fix error path

From	Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH 2/2] bfin_mac: fix error path
Date	2016-01-08 12:30 +0100
Message-ID	<qODp0-60g-7@gated-at.bofh.it> (permalink)
References	<qODp0-60g-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

While building blackfin defconfig we were getting a build warning:
warning: label 'out_err_irq_alloc' defined but not used.

Commit e7f4dc3536a4 ("mdio: Move allocation of interrupts into core")
removed the label out_err_mdiobus_register but then mistakenly jumped to
out_err_alloc. But it was actually supposed to jump to out_err_irq_alloc.

Fixes: e7f4dc3536a4 ("mdio: Move allocation of interrupts into core")
Cc: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---
 drivers/net/ethernet/adi/bfin_mac.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/adi/bfin_mac.c b/drivers/net/ethernet/adi/bfin_mac.c
index 6f3432a..5ddfd0e 100644
--- a/drivers/net/ethernet/adi/bfin_mac.c
+++ b/drivers/net/ethernet/adi/bfin_mac.c
@@ -1857,7 +1857,7 @@ static int bfin_mii_bus_probe(struct platform_device *pdev)
 	rc = mdiobus_register(miibus);
 	if (rc) {
 		dev_err(&pdev->dev, "Cannot register MDIO bus!\n");
-		goto out_err_alloc;
+		goto out_err_irq_alloc;
 	}
 
 	platform_set_drvdata(pdev, miibus);
-- 
1.9.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 2/2] bfin_mac: fix error path Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-01-08 12:30 +0100
  Re: [PATCH 2/2] bfin_mac: fix error path David Miller <davem@davemloft.net> - 2016-01-11 04:50 +0100

csiph-web