Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1304398 > unrolled thread

[PATCH 2/2] bfin_mac: fix error path

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH 2/2] bfin_mac: fix error path Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-01-08 12:30 +0100
    Re: [PATCH 2/2] bfin_mac: fix error path David Miller <davem@davemloft.net> - 2016-01-11 04:50 +0100

#1304398 — [PATCH 2/2] bfin_mac: fix error path

While building blackfin defconfig we were getting a build warning:
warning: label 'out_err_irq_alloc' defined but not used.

Commit e7f4dc3536a4 ("mdio: Move allocation of interrupts into core")
removed the label out_err_mdiobus_register but then mistakenly jumped to
out_err_alloc. But it was actually supposed to jump to out_err_irq_alloc.

Fixes: e7f4dc3536a4 ("mdio: Move allocation of interrupts into core")
Cc: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---
 drivers/net/ethernet/adi/bfin_mac.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/adi/bfin_mac.c b/drivers/net/ethernet/adi/bfin_mac.c
index 6f3432a..5ddfd0e 100644
--- a/drivers/net/ethernet/adi/bfin_mac.c
+++ b/drivers/net/ethernet/adi/bfin_mac.c
@@ -1857,7 +1857,7 @@ static int bfin_mii_bus_probe(struct platform_device *pdev)
 	rc = mdiobus_register(miibus);
 	if (rc) {
 		dev_err(&pdev->dev, "Cannot register MDIO bus!\n");
-		goto out_err_alloc;
+		goto out_err_irq_alloc;
 	}
 
 	platform_set_drvdata(pdev, miibus);
-- 
1.9.1

[toc] | [next] | [standalone]

#1305806

From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Date: Fri,  8 Jan 2016 16:58:15 +0530

> While building blackfin defconfig we were getting a build warning:
> warning: label 'out_err_irq_alloc' defined but not used.
> 
> Commit e7f4dc3536a4 ("mdio: Move allocation of interrupts into core")
> removed the label out_err_mdiobus_register but then mistakenly jumped to
> out_err_alloc. But it was actually supposed to jump to out_err_irq_alloc.
> 
> Fixes: e7f4dc3536a4 ("mdio: Move allocation of interrupts into core")
> Cc: Andrew Lunn <andrew@lunn.ch>
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>

Applied.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web