Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1300302

Re: [PATCH] ubifs: Fix error codes in ubifs_iget()

Show all headers | View raw

Am 03.01.2016 um 14:54 schrieb Artem Bityutskiy:
> On Sun, 2016-01-03 at 15:51 +0200, Artem Bityutskiy wrote:
>> On Sat, 2016-01-02 at 23:11 +0100, Richard Weinberger wrote:
>>> We cannot use positive error codes in ERR_PTR().
>>> IS_ERR() won't catch them.
>>
>> Right, but why there is a "err = -EINVAL;" when at 'out_invalid'.
> 
> Sorry Richard, I edited the sentence and did not notice it was messy.
> 
> Here is what I wanted to say: right, but there is a "err = -EINVAL' at
> the end of 'out_invalid'.

Oh, you're right. I've missed this somehow.
Let's ignore this patch. :)

Thanks,
//richard


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] ubifs: Fix error codes in ubifs_iget() Richard Weinberger <richard@nod.at> - 2016-01-02 23:20 +0100
  Re: [PATCH] ubifs: Fix error codes in ubifs_iget() Richard Weinberger <richard@nod.at> - 2016-01-03 15:00 +0100
  Re: [PATCH] ubifs: Fix error codes in ubifs_iget() Artem Bityutskiy <dedekind1@gmail.com> - 2016-01-03 15:00 +0100
    Re: [PATCH] ubifs: Fix error codes in ubifs_iget() Artem Bityutskiy <dedekind1@gmail.com> - 2016-01-03 15:00 +0100

csiph-web