Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1300303

Re: [PATCH] ubifs: Fix error codes in ubifs_iget()

From Artem Bityutskiy <dedekind1@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH] ubifs: Fix error codes in ubifs_iget()
Date 2016-01-03 15:00 +0100
Message-ID <qMRmp-69u-3@gated-at.bofh.it> (permalink)
References <qMCGJ-5oA-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Sat, 2016-01-02 at 23:11 +0100, Richard Weinberger wrote:
> We cannot use positive error codes in ERR_PTR().
> IS_ERR() won't catch them.

Right, but why there is a "err = -EINVAL;" when at 'out_invalid'.

> Cc: stable@vger.kernel.org
> Signed-off-by: Richard Weinberger <richard@nod.at>

I do not see a bug, but I see a removal of a useful code which lets you
understand what verification failed. Do I miss something?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] ubifs: Fix error codes in ubifs_iget() Richard Weinberger <richard@nod.at> - 2016-01-02 23:20 +0100
  Re: [PATCH] ubifs: Fix error codes in ubifs_iget() Richard Weinberger <richard@nod.at> - 2016-01-03 15:00 +0100
  Re: [PATCH] ubifs: Fix error codes in ubifs_iget() Artem Bityutskiy <dedekind1@gmail.com> - 2016-01-03 15:00 +0100
    Re: [PATCH] ubifs: Fix error codes in ubifs_iget() Artem Bityutskiy <dedekind1@gmail.com> - 2016-01-03 15:00 +0100

csiph-web