Re: [PATCH] pinctrl: mediatek: convert to arch_initcall

From	Mark Brown <broonie@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] pinctrl: mediatek: convert to arch_initcall
Date	2015-12-30 18:30 +0100
Message-ID	<qLsJs-15B-11@gated-at.bofh.it> (permalink)
References	<qIvua-4Bu-11@gated-at.bofh.it> <qIwTg-5Bi-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Tue, Dec 22, 2015 at 04:11:47PM +0100, Linus Walleij wrote:
> On Tue, Dec 22, 2015 at 2:46 PM, Daniel Kurtz <djkurtz@chromium.org> wrote:

> > Move pinctrl initialization earlier in boot so that real devices can find
> > their pctldev without probe deferring.
> (...)
> > -module_init(mtk_pinctrl_init);
> > +arch_initcall(mtk_pinctrl_init);

> So I see why you're doing this (because of wanting to avoid nasty boot
> probe deferrals, right?) and I'm going to apply it, because the work
> with probe ordering is still in the works, but I'd like some general
> ARM people to come in with opinions.

I really don't think we should be applying this sort of stuff unless
things are actively broken right now.  It's a bit of a rabbit hole we
could spend a long time going down tweaking things for different
systems in the same way that tweaking the link order can be and it masks
the underlying issues.

Thread

[PATCH] pinctrl: mediatek: convert to arch_initcall Daniel Kurtz <djkurtz@chromium.org> - 2015-12-22 14:50 +0100
  Re: [PATCH] pinctrl: mediatek: convert to arch_initcall Linus Walleij <linus.walleij@linaro.org> - 2015-12-22 16:20 +0100
    Re: [PATCH] pinctrl: mediatek: convert to arch_initcall Mark Brown <broonie@kernel.org> - 2015-12-30 18:30 +0100
      Re: [PATCH] pinctrl: mediatek: convert to arch_initcall Daniel Kurtz <djkurtz@chromium.org> - 2015-12-31 14:50 +0100
        Re: [PATCH] pinctrl: mediatek: convert to arch_initcall Mark Brown <broonie@kernel.org> - 2015-12-31 23:10 +0100
          Re: [PATCH] pinctrl: mediatek: convert to arch_initcall Daniel Kurtz <djkurtz@chromium.org> - 2016-01-01 03:00 +0100
            Re: [PATCH] pinctrl: mediatek: convert to arch_initcall Matthias Brugger <matthias.bgg@gmail.com> - 2016-01-01 15:30 +0100
              Re: [PATCH] pinctrl: mediatek: convert to arch_initcall Linus Walleij <linus.walleij@linaro.org> - 2016-01-01 18:30 +0100

csiph-web