Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1299669

Re: [PATCH] pinctrl: mediatek: convert to arch_initcall

Show all headers | View raw

On Thu, Dec 31, 2015 at 1:22 AM, Mark Brown <broonie@kernel.org> wrote:
>
> On Tue, Dec 22, 2015 at 04:11:47PM +0100, Linus Walleij wrote:
> > On Tue, Dec 22, 2015 at 2:46 PM, Daniel Kurtz <djkurtz@chromium.org> wrote:
>
> > > Move pinctrl initialization earlier in boot so that real devices can find
> > > their pctldev without probe deferring.
> > (...)
> > > -module_init(mtk_pinctrl_init);
> > > +arch_initcall(mtk_pinctrl_init);
>
> > So I see why you're doing this (because of wanting to avoid nasty boot
> > probe deferrals, right?) and I'm going to apply it, because the work
> > with probe ordering is still in the works, but I'd like some general
> > ARM people to come in with opinions.
>
> I really don't think we should be applying this sort of stuff unless
> things are actively broken right now.  It's a bit of a rabbit hole we
> could spend a long time going down tweaking things for different
> systems in the same way that tweaking the link order can be and it masks
> the underlying issues.

Things are actively broken right now, in the sense that there are many
needless probe deferrals on boot.
These are pinctrl drivers, which are required to load before every
other driver that requests a gpio.
AFAICT, the pinctrl is part of the platform "architecture", hence why
I suggest we move this to arch_initcall().
arch_initcall() is also consistent with 39 other pinctrl drivers in
drivers/pinctrl.
19 others use subsys_initcall(), core_initcall() or
postcore_initcall(), any of which would also work.

-Dan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] pinctrl: mediatek: convert to arch_initcall Daniel Kurtz <djkurtz@chromium.org> - 2015-12-22 14:50 +0100
  Re: [PATCH] pinctrl: mediatek: convert to arch_initcall Linus Walleij <linus.walleij@linaro.org> - 2015-12-22 16:20 +0100
    Re: [PATCH] pinctrl: mediatek: convert to arch_initcall Mark Brown <broonie@kernel.org> - 2015-12-30 18:30 +0100
      Re: [PATCH] pinctrl: mediatek: convert to arch_initcall Daniel Kurtz <djkurtz@chromium.org> - 2015-12-31 14:50 +0100
        Re: [PATCH] pinctrl: mediatek: convert to arch_initcall Mark Brown <broonie@kernel.org> - 2015-12-31 23:10 +0100
          Re: [PATCH] pinctrl: mediatek: convert to arch_initcall Daniel Kurtz <djkurtz@chromium.org> - 2016-01-01 03:00 +0100
            Re: [PATCH] pinctrl: mediatek: convert to arch_initcall Matthias Brugger <matthias.bgg@gmail.com> - 2016-01-01 15:30 +0100
              Re: [PATCH] pinctrl: mediatek: convert to arch_initcall Linus Walleij <linus.walleij@linaro.org> - 2016-01-01 18:30 +0100
                Re: [PATCH] pinctrl: mediatek: convert to arch_initcall Mark Brown <broonie@kernel.org> - 2016-01-04 18:20 +0100
            Re: [PATCH] pinctrl: mediatek: convert to arch_initcall Mark Brown <broonie@kernel.org> - 2016-01-04 19:30 +0100

csiph-web