Re: crypto: use-after-free in alg_bind

From	Herbert Xu <herbert@gondor.apana.org.au>
Newsgroups	linux.kernel
Subject	Re: crypto: use-after-free in alg_bind
Date	2015-12-30 14:00 +0100
Message-ID	<qLow9-6JH-5@gated-at.bofh.it> (permalink)
References	(2 earlier) <qLmaZ-5mj-7@gated-at.bofh.it> <qLmE2-5wj-9@gated-at.bofh.it> <qLmE2-5wj-13@gated-at.bofh.it> <qLo38-6zJ-9@gated-at.bofh.it> <qLomt-6Gu-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Dec 30, 2015 at 01:45:15PM +0100, Dmitry Vyukov wrote:
>
> This seems to be a zero-day. Should we CC stable@vger.kernel.org ?
> 
> Code in 03c8efc1ffeb6b82a22c1af8dd908af349563314 (Oct 19, 2010) contained:
> 
> +       sock_init_data(newsock, sk2);
> +
> +       err = type->accept(ask->private, sk2);
> +       if (err) {
> +               sk_free(sk2);
> +               goto unlock;
> +       }
> 
> There were no sock_graft call, but sock_init_data also sets
> newsock->sk = sk2, which seems to be enough for the double-free.

But accept only started failing because the newly added has_key
check.  Otherwise the only way for it to fail is if we run out
of memory.

IOW the bug can only be easily triggered in the current crypto tree.

Cheers,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

crypto: use-after-free in alg_bind Dmitry Vyukov <dvyukov@google.com> - 2015-12-29 21:20 +0100
  Re: crypto: use-after-free in alg_bind Herbert Xu <herbert@gondor.apana.org.au> - 2015-12-30 02:30 +0100
    Re: crypto: use-after-free in alg_bind Dmitry Vyukov <dvyukov@google.com> - 2015-12-30 11:30 +0100
      Re: crypto: use-after-free in alg_bind Herbert Xu <herbert@gondor.apana.org.au> - 2015-12-30 12:00 +0100
        Re: crypto: use-after-free in alg_bind Dmitry Vyukov <dvyukov@google.com> - 2015-12-30 12:00 +0100
          Re: crypto: use-after-free in alg_bind Herbert Xu <herbert@gondor.apana.org.au> - 2015-12-30 13:30 +0100
            Re: crypto: use-after-free in alg_bind Dmitry Vyukov <dvyukov@google.com> - 2015-12-30 13:50 +0100
              Re: crypto: use-after-free in alg_bind Herbert Xu <herbert@gondor.apana.org.au> - 2015-12-30 14:00 +0100

csiph-web