Re: crypto: use-after-free in alg_bind

From	Herbert Xu <herbert@gondor.apana.org.au>
Newsgroups	linux.kernel
Subject	Re: crypto: use-after-free in alg_bind
Date	2015-12-30 12:00 +0100
Message-ID	<qLmE2-5wj-9@gated-at.bofh.it> (permalink)
References	<qL8Uq-5fn-13@gated-at.bofh.it> <qLdKq-8cX-5@gated-at.bofh.it> <qLmaZ-5mj-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Dec 30, 2015 at 11:19:45AM +0100, Dmitry Vyukov wrote:
>
> This use-after-free does not reproduce on every run. It seems to be
> triggered by some race. Try to run the program in a parallel loop.
> I use stress tool for this:
> https://github.com/golang/tools/blob/master/cmd/stress/stress.go
> If you have Go toolchain installed, then then following will do:
> $ go get golang.org/x/tools/cmd/stress
> $ stress -p 16 ./a.out

I've tried a few thousand instances of it but still no luck.
> 
> 
> diff --git a/crypto/af_alg.c b/crypto/af_alg.c
> index a8e7aa3..82a7dcd 100644

There are a few missing hunks in your patch and the patch to
if_alg.h is missing.

So please start with the current crypto tree and then apply the
latest version (v2) of "crypto: af_alg - Disallow bind/setkey/...
after accept(2)" and try again.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

crypto: use-after-free in alg_bind Dmitry Vyukov <dvyukov@google.com> - 2015-12-29 21:20 +0100
  Re: crypto: use-after-free in alg_bind Herbert Xu <herbert@gondor.apana.org.au> - 2015-12-30 02:30 +0100
    Re: crypto: use-after-free in alg_bind Dmitry Vyukov <dvyukov@google.com> - 2015-12-30 11:30 +0100
      Re: crypto: use-after-free in alg_bind Herbert Xu <herbert@gondor.apana.org.au> - 2015-12-30 12:00 +0100
        Re: crypto: use-after-free in alg_bind Dmitry Vyukov <dvyukov@google.com> - 2015-12-30 12:00 +0100
          Re: crypto: use-after-free in alg_bind Herbert Xu <herbert@gondor.apana.org.au> - 2015-12-30 13:30 +0100
            Re: crypto: use-after-free in alg_bind Dmitry Vyukov <dvyukov@google.com> - 2015-12-30 13:50 +0100
              Re: crypto: use-after-free in alg_bind Herbert Xu <herbert@gondor.apana.org.au> - 2015-12-30 14:00 +0100

csiph-web