Re: [PATCH] gpiolib: fix warning about iterator

From	Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] gpiolib: fix warning about iterator
Date	2015-12-27 14:40 +0100
Message-ID	<qKjIe-7Ca-9@gated-at.bofh.it> (permalink)
References	<qJRVD-6x0-1@gated-at.bofh.it> <qK4Jc-6fM-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat, Dec 26, 2015 at 10:31:15PM +0100, Linus Walleij wrote:
> On Sat, Dec 26, 2015 at 8:58 AM, Sudip Mukherjee
> <sudipm.mukherjee@gmail.com> wrote:
> 
> > We were getting build warning about "iterator" being used uninitialized.
> > Use iterator properly to fix the build warning and in the process remove
> > the variable "pos" which is not required now.
> >
> > Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> 
> Aha there is a real patch solving the problem. Sorry Ross,
> had to drop your patch and replace it with this.
> 
> Patch applied!

oops .. i think i have a small mistake in the patch. After the loop for
list_for_each_entry ends we are having:
        if (iterator->base + iterator->ngpio <= chip->base)
	                goto found;

But at the end of the loop iterator will point to head. The condition in
the loop is &pos->member != (head).
I am sending v2 as reply to this thread. It will be great if you can
review and apply that instead of this one.
Sorry for the inconvenience. I guess christmas effect. :)

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH] gpiolib: fix warning about iterator Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-12-26 09:00 +0100
  Re: [PATCH] gpiolib: fix warning about iterator Linus Walleij <linus.walleij@linaro.org> - 2015-12-26 22:40 +0100
    Re: [PATCH] gpiolib: fix warning about iterator Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-12-27 14:40 +0100
    [PATCH v2] gpiolib: fix warning about iterator Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-12-27 14:40 +0100
      Re: [PATCH v2] gpiolib: fix warning about iterator Linus Walleij <linus.walleij@linaro.org> - 2015-12-28 03:50 +0100

csiph-web