Re: [PATCH 1/2] devicetree: sound: add binding for WM8974 codec

From	Mark Brown <broonie@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] devicetree: sound: add binding for WM8974 codec
Date	2015-12-16 20:00 +0100
Message-ID	<qGpsS-5tw-5@gated-at.bofh.it> (permalink)
References	<qGk09-2ba-5@gated-at.bofh.it> <qGktb-2l3-3@gated-at.bofh.it> <qGkCR-2of-1@gated-at.bofh.it> <qGkMz-2rE-35@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Wed, Dec 16, 2015 at 01:54:20PM +0000, Måns Rullgård wrote:
> Mark Brown <broonie@kernel.org> writes:

> > I need the patch in a form I can apply.

> I assumed your email client had some way of displaying the message I
> replied to.  Guess I was wrong.

My workflow for reviewing and applying patches is based around my inbox,
as are most review flows in the kernel - things that aren't in my inbox
*might* get looked at but it's unreliable.

> > You can't blindly rely on get_maintainers, it's prone to both false
> > positives (CCing too many people, especially if you enable git matching
> > when it often starts spamming people who are just doing global cleanups)
> > and false negatives (if you don't enable git matching and it misses
> > people who care about a specific driver).

> So in short, I'm supposed to magically divine who wants to see what.

You're supposed to do like SubmittingPatches suggests make a judgement
call based on things like looking at MAINTAINERS and the people that git
shows are reviewing and applying patches or otherwise seem relevant -
it's not really something that can be fully automated (for example, it
might make sense to CC someone who worked on the specific thing you're
changing even if they don't commonly review the file as a whole).

Looking at git history will also help you ensure that the style you're
presenting your changes in (for example things like the subject line)
matches the general style people are using.

Thread

[PATCH 1/2] devicetree: sound: add binding for WM8974 codec Mans Rullgard <mans@mansr.com> - 2015-12-16 14:10 +0100
  Re: [PATCH 1/2] devicetree: sound: add binding for WM8974 codec Måns Rullgård <mans@mansr.com> - 2015-12-16 14:40 +0100
    Re: [PATCH 1/2] devicetree: sound: add binding for WM8974 codec Mark Brown <broonie@kernel.org> - 2015-12-16 14:50 +0100
      Re: [PATCH 1/2] devicetree: sound: add binding for WM8974 codec Måns Rullgård <mans@mansr.com> - 2015-12-16 15:00 +0100
        Re: [PATCH 1/2] devicetree: sound: add binding for WM8974 codec Mark Brown <broonie@kernel.org> - 2015-12-16 20:00 +0100
    Re: [PATCH 1/2] devicetree: sound: add binding for WM8974 codec Rob Herring <robh@kernel.org> - 2015-12-19 05:20 +0100
  [PATCH] devicetree: sound: add binding for WM8974 codec Mans Rullgard <mans@mansr.com> - 2015-12-16 15:00 +0100
    Re: [PATCH] devicetree: sound: add binding for WM8974 codec Rob Herring <robh@kernel.org> - 2015-12-19 05:20 +0100

csiph-web