Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1292939 > unrolled thread

[PATCH 1/2] devicetree: sound: add binding for WM8974 codec

Started byMans Rullgard <mans@mansr.com>
First post2015-12-16 14:10 +0100
Last post2015-12-19 05:20 +0100
Articles 8 — 4 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH 1/2] devicetree: sound: add binding for WM8974 codec Mans Rullgard <mans@mansr.com> - 2015-12-16 14:10 +0100
    Re: [PATCH 1/2] devicetree: sound: add binding for WM8974 codec Måns Rullgård <mans@mansr.com> - 2015-12-16 14:40 +0100
      Re: [PATCH 1/2] devicetree: sound: add binding for WM8974 codec Mark Brown <broonie@kernel.org> - 2015-12-16 14:50 +0100
        Re: [PATCH 1/2] devicetree: sound: add binding for WM8974 codec Måns Rullgård <mans@mansr.com> - 2015-12-16 15:00 +0100
          Re: [PATCH 1/2] devicetree: sound: add binding for WM8974 codec Mark Brown <broonie@kernel.org> - 2015-12-16 20:00 +0100
      Re: [PATCH 1/2] devicetree: sound: add binding for WM8974 codec Rob Herring <robh@kernel.org> - 2015-12-19 05:20 +0100
    [PATCH] devicetree: sound: add binding for WM8974 codec Mans Rullgard <mans@mansr.com> - 2015-12-16 15:00 +0100
      Re: [PATCH] devicetree: sound: add binding for WM8974 codec Rob Herring <robh@kernel.org> - 2015-12-19 05:20 +0100

#1292939 — [PATCH 1/2] devicetree: sound: add binding for WM8974 codec

FromMans Rullgard <mans@mansr.com>
Date2015-12-16 14:10 +0100
Subject[PATCH 1/2] devicetree: sound: add binding for WM8974 codec
Message-ID<qGk09-2ba-5@gated-at.bofh.it>
This adds a binding for the Wolfson WM8974 mono audio codec.

Signed-off-by: Mans Rullgard <mans@mansr.com>
---
The Linux driver for this device currently only supports I2C, but SPI
could easily be added if necessary, and DT bindings are supposed to be
generic.
---
 Documentation/devicetree/bindings/sound/wlf,wm8974.txt | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/sound/wlf,wm8974.txt

diff --git a/Documentation/devicetree/bindings/sound/wlf,wm8974.txt b/Documentation/devicetree/bindings/sound/wlf,wm8974.txt
new file mode 100644
index 0000000..01d3a7c
--- /dev/null
+++ b/Documentation/devicetree/bindings/sound/wlf,wm8974.txt
@@ -0,0 +1,15 @@
+WM8974 audio CODEC
+
+This device supports both I2C and SPI (configured with pin strapping
+on the board).
+
+Required properties:
+  - compatible: "wlf,wm8974"
+  - reg: the I2C address or SPI chip select number of the device
+
+Examples:
+
+codec: wm8974@1a {
+	compatible = "wlf,wm8974";
+	reg = <0x1a>;
+};
-- 
2.6.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1292955

FromMåns Rullgård <mans@mansr.com>
Date2015-12-16 14:40 +0100
Message-ID<qGktb-2l3-3@gated-at.bofh.it>
In reply to#1292939
Mark,

This is the 1/1 you were missing.

Am I the only one who is annoyed by scripts/get_maintainer.pl not
returning all the addresses it should in cases like this?  Is there some
trick I'm missing?

Mans Rullgard <mans@mansr.com> writes:

> This adds a binding for the Wolfson WM8974 mono audio codec.
>
> Signed-off-by: Mans Rullgard <mans@mansr.com>
> ---
> The Linux driver for this device currently only supports I2C, but SPI
> could easily be added if necessary, and DT bindings are supposed to be
> generic.
> ---
>  Documentation/devicetree/bindings/sound/wlf,wm8974.txt | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/sound/wlf,wm8974.txt
>
> diff --git a/Documentation/devicetree/bindings/sound/wlf,wm8974.txt b/Documentation/devicetree/bindings/sound/wlf,wm8974.txt
> new file mode 100644
> index 0000000..01d3a7c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/wlf,wm8974.txt
> @@ -0,0 +1,15 @@
> +WM8974 audio CODEC
> +
> +This device supports both I2C and SPI (configured with pin strapping
> +on the board).
> +
> +Required properties:
> +  - compatible: "wlf,wm8974"
> +  - reg: the I2C address or SPI chip select number of the device
> +
> +Examples:
> +
> +codec: wm8974@1a {
> +	compatible = "wlf,wm8974";
> +	reg = <0x1a>;
> +};
> -- 
> 2.6.3
>

-- 
Måns Rullgård
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1292959

FromMark Brown <broonie@kernel.org>
Date2015-12-16 14:50 +0100
Message-ID<qGkCR-2of-1@gated-at.bofh.it>
In reply to#1292955

[Multipart message — attachments visible in raw view] — view raw

On Wed, Dec 16, 2015 at 01:31:30PM +0000, Måns Rullgård wrote:

> This is the 1/1 you were missing.

I need the patch in a form I can apply.

> Am I the only one who is annoyed by scripts/get_maintainer.pl not
> returning all the addresses it should in cases like this?  Is there some
> trick I'm missing?

You can't blindly rely on get_maintainers, it's prone to both false
positives (CCing too many people, especially if you enable git matching
when it often starts spamming people who are just doing global cleanups)
and false negatives (if you don't enable git matching and it misses
people who care about a specific driver).

[toc] | [prev] | [next] | [standalone]

#1292970

FromMåns Rullgård <mans@mansr.com>
Date2015-12-16 15:00 +0100
Message-ID<qGkMz-2rE-35@gated-at.bofh.it>
In reply to#1292959
Mark Brown <broonie@kernel.org> writes:

> On Wed, Dec 16, 2015 at 01:31:30PM +0000, Måns Rullgård wrote:
>
>> This is the 1/1 you were missing.
>
> I need the patch in a form I can apply.

I assumed your email client had some way of displaying the message I
replied to.  Guess I was wrong.

>> Am I the only one who is annoyed by scripts/get_maintainer.pl not
>> returning all the addresses it should in cases like this?  Is there some
>> trick I'm missing?
>
> You can't blindly rely on get_maintainers, it's prone to both false
> positives (CCing too many people, especially if you enable git matching
> when it often starts spamming people who are just doing global cleanups)
> and false negatives (if you don't enable git matching and it misses
> people who care about a specific driver).

So in short, I'm supposed to magically divine who wants to see what.

-- 
Måns Rullgård
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1293309

FromMark Brown <broonie@kernel.org>
Date2015-12-16 20:00 +0100
Message-ID<qGpsS-5tw-5@gated-at.bofh.it>
In reply to#1292970

[Multipart message — attachments visible in raw view] — view raw

On Wed, Dec 16, 2015 at 01:54:20PM +0000, Måns Rullgård wrote:
> Mark Brown <broonie@kernel.org> writes:

> > I need the patch in a form I can apply.

> I assumed your email client had some way of displaying the message I
> replied to.  Guess I was wrong.

My workflow for reviewing and applying patches is based around my inbox,
as are most review flows in the kernel - things that aren't in my inbox
*might* get looked at but it's unreliable.

> > You can't blindly rely on get_maintainers, it's prone to both false
> > positives (CCing too many people, especially if you enable git matching
> > when it often starts spamming people who are just doing global cleanups)
> > and false negatives (if you don't enable git matching and it misses
> > people who care about a specific driver).

> So in short, I'm supposed to magically divine who wants to see what.

You're supposed to do like SubmittingPatches suggests make a judgement
call based on things like looking at MAINTAINERS and the people that git
shows are reviewing and applying patches or otherwise seem relevant -
it's not really something that can be fully automated (for example, it
might make sense to CC someone who worked on the specific thing you're
changing even if they don't commonly review the file as a whole).

Looking at git history will also help you ensure that the style you're
presenting your changes in (for example things like the subject line)
matches the general style people are using.

[toc] | [prev] | [next] | [standalone]

#1295296

FromRob Herring <robh@kernel.org>
Date2015-12-19 05:20 +0100
Message-ID<qHh9V-6J4-29@gated-at.bofh.it>
In reply to#1292955
On Wed, Dec 16, 2015 at 01:31:30PM +0000, Måns Rullgård wrote:
> Mark,
> 
> This is the 1/1 you were missing.
> 
> Am I the only one who is annoyed by scripts/get_maintainer.pl not
> returning all the addresses it should in cases like this?  Is there some
> trick I'm missing?

Documentation/devicetree/bindings/sound/ should probably be listed with 
the ALSA maintainer entry.

Rob
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1292969 — [PATCH] devicetree: sound: add binding for WM8974 codec

FromMans Rullgard <mans@mansr.com>
Date2015-12-16 15:00 +0100
Subject[PATCH] devicetree: sound: add binding for WM8974 codec
Message-ID<qGkMz-2rE-31@gated-at.bofh.it>
In reply to#1292939
This adds a binding for the Wolfson WM8974 mono audio codec.

Signed-off-by: Mans Rullgard <mans@mansr.com>
---
Sending this patch again, this time including Mark Brown.
---
 Documentation/devicetree/bindings/sound/wlf,wm8974.txt | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/sound/wlf,wm8974.txt

diff --git a/Documentation/devicetree/bindings/sound/wlf,wm8974.txt b/Documentation/devicetree/bindings/sound/wlf,wm8974.txt
new file mode 100644
index 0000000..01d3a7c
--- /dev/null
+++ b/Documentation/devicetree/bindings/sound/wlf,wm8974.txt
@@ -0,0 +1,15 @@
+WM8974 audio CODEC
+
+This device supports both I2C and SPI (configured with pin strapping
+on the board).
+
+Required properties:
+  - compatible: "wlf,wm8974"
+  - reg: the I2C address or SPI chip select number of the device
+
+Examples:
+
+codec: wm8974@1a {
+	compatible = "wlf,wm8974";
+	reg = <0x1a>;
+};
-- 
2.6.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1295294 — Re: [PATCH] devicetree: sound: add binding for WM8974 codec

FromRob Herring <robh@kernel.org>
Date2015-12-19 05:20 +0100
SubjectRe: [PATCH] devicetree: sound: add binding for WM8974 codec
Message-ID<qHh9U-6J4-23@gated-at.bofh.it>
In reply to#1292969
On Wed, Dec 16, 2015 at 01:55:13PM +0000, Mans Rullgard wrote:
> This adds a binding for the Wolfson WM8974 mono audio codec.
> 
> Signed-off-by: Mans Rullgard <mans@mansr.com>
> ---
> Sending this patch again, this time including Mark Brown.
> ---
>  Documentation/devicetree/bindings/sound/wlf,wm8974.txt | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/sound/wlf,wm8974.txt

This could go in i2c/trivial-devices.txt if this is it, but standalone 
is fine too.

Acked-by: Rob Herring <robh@kernel.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web