Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1291979
| From | Xiao Guangrong <guangrong.xiao@linux.intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 09/11] KVM: MMU: simplify mmu_need_write_protect |
| Date | 2015-12-15 10:40 +0100 |
| Message-ID | <qFUfp-2at-17@gated-at.bofh.it> (permalink) |
| References | <qABwJ-7d9-5@gated-at.bofh.it> <qABwK-7d9-9@gated-at.bofh.it> <qFTsZ-1AY-5@gated-at.bofh.it> <qFTCH-1Fp-19@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 12/15/2015 04:47 PM, Kai Huang wrote: >> A further thinking is can we move it to mmu_need_write_protect? Passing can_unsync as parameter to >> kvm_unsync_pages sounds a little bit odd. >> >>> + >>> if (s->unsync) >>> continue; >>> WARN_ON(s->role.level != PT_PAGE_TABLE_LEVEL); >> How about large page mapping? Such as if guest uses 2M mapping and its shadow is indirect, does >> above WARN_ON still meet? As you removed the PT level check in mmu_need_write_protect. >> >> Thanks, >> -Kai > Btw I also think this patch can be merged with patch 6. We can not as it depends on patch 8. ;) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH 09/11] KVM: MMU: simplify mmu_need_write_protect Kai Huang <kai.huang@linux.intel.com> - 2015-12-15 09:50 +0100
Re: [PATCH 09/11] KVM: MMU: simplify mmu_need_write_protect Kai Huang <kai.huang@linux.intel.com> - 2015-12-15 10:00 +0100
Re: [PATCH 09/11] KVM: MMU: simplify mmu_need_write_protect Xiao Guangrong <guangrong.xiao@linux.intel.com> - 2015-12-15 10:40 +0100
Re: [PATCH 09/11] KVM: MMU: simplify mmu_need_write_protect Xiao Guangrong <guangrong.xiao@linux.intel.com> - 2015-12-15 10:40 +0100
Re: [PATCH 09/11] KVM: MMU: simplify mmu_need_write_protect Kai Huang <kai.huang@linux.intel.com> - 2015-12-16 09:20 +0100
Re: [PATCH 09/11] KVM: MMU: simplify mmu_need_write_protect Xiao Guangrong <guangrong.xiao@linux.intel.com> - 2015-12-16 10:00 +0100
Re: [PATCH 09/11] KVM: MMU: simplify mmu_need_write_protect Kai Huang <kai.huang@linux.intel.com> - 2015-12-17 04:00 +0100
csiph-web