Groups > linux.kernel > #1291979

Re: [PATCH 09/11] KVM: MMU: simplify mmu_need_write_protect

Path	csiph.com!news.mixmin.net!weretis.net!feeder4.news.weretis.net!storethat.news.telefonica.de!telefonica.de!news.panservice.it!bofh.it!news.nic.it!robomod
From	Xiao Guangrong <guangrong.xiao@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 09/11] KVM: MMU: simplify mmu_need_write_protect
Date	Tue, 15 Dec 2015 10:40:03 +0100
Message-ID	<qFUfp-2at-17@gated-at.bofh.it> (permalink)
References	<qABwJ-7d9-5@gated-at.bofh.it> <qABwK-7d9-9@gated-at.bofh.it> <qFTsZ-1AY-5@gated-at.bofh.it> <qFTCH-1Fp-19@gated-at.bofh.it>
X-Original-To	Kai Huang <kai.huang@linux.intel.com>, pbonzini@redhat.com
X-Extloop1	1
X-Ironport-Av	E=Sophos;i="5.20,431,1444719600"; d="scan'208";a="861000192"
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0
MIME-Version	1.0
Content-Type	text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding	7bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	25
Organization	linux.* mail to news gateway
X-Original-Cc	gleb@kernel.org, mtosatti@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org
X-Original-Date	Tue, 15 Dec 2015 17:26:49 +0800
X-Original-Message-ID	<566FDCD9.6080303@linux.intel.com>
X-Original-References	<1448907973-36066-1-git-send-email-guangrong.xiao@linux.intel.com> <1448907973-36066-10-git-send-email-guangrong.xiao@linux.intel.com> <566FD2A1.7010601@linux.intel.com> <566FD39B.6080200@linux.intel.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1291979

Show key headers only | View raw


On 12/15/2015 04:47 PM, Kai Huang wrote:

>> A further thinking is can we move it to mmu_need_write_protect? Passing can_unsync as parameter to
>> kvm_unsync_pages sounds a little bit odd.
>>
>>> +
>>>           if (s->unsync)
>>>               continue;
>>>           WARN_ON(s->role.level != PT_PAGE_TABLE_LEVEL);
>> How about large page mapping? Such as if guest uses 2M mapping and its shadow is indirect, does
>> above WARN_ON still meet? As you removed the PT level check in mmu_need_write_protect.
>>
>> Thanks,
>> -Kai
> Btw I also think this patch can be merged with patch 6.

We can not as it depends on patch 8. ;)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

Re: [PATCH 09/11] KVM: MMU: simplify mmu_need_write_protect Kai Huang <kai.huang@linux.intel.com> - 2015-12-15 09:50 +0100
  Re: [PATCH 09/11] KVM: MMU: simplify mmu_need_write_protect Kai Huang <kai.huang@linux.intel.com> - 2015-12-15 10:00 +0100
    Re: [PATCH 09/11] KVM: MMU: simplify mmu_need_write_protect Xiao Guangrong <guangrong.xiao@linux.intel.com> - 2015-12-15 10:40 +0100
  Re: [PATCH 09/11] KVM: MMU: simplify mmu_need_write_protect Xiao Guangrong <guangrong.xiao@linux.intel.com> - 2015-12-15 10:40 +0100
    Re: [PATCH 09/11] KVM: MMU: simplify mmu_need_write_protect Kai Huang <kai.huang@linux.intel.com> - 2015-12-16 09:20 +0100
      Re: [PATCH 09/11] KVM: MMU: simplify mmu_need_write_protect Xiao Guangrong <guangrong.xiao@linux.intel.com> - 2015-12-16 10:00 +0100
        Re: [PATCH 09/11] KVM: MMU: simplify mmu_need_write_protect Kai Huang <kai.huang@linux.intel.com> - 2015-12-17 04:00 +0100

csiph-web