Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1281759

Re: [PATCH 1/2] regulator: Add brcm,bcm63xx-regulator device tree binding

From Mark Brown <broonie@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH 1/2] regulator: Add brcm,bcm63xx-regulator device tree binding
Date 2015-12-02 14:00 +0100
Message-ID <qBfaO-7ik-23@gated-at.bofh.it> (permalink)
References <qzV4t-5Ew-11@gated-at.bofh.it> <qAvB0-3vl-5@gated-at.bofh.it> <qADoR-8nQ-5@gated-at.bofh.it> <qB1rc-76P-19@gated-at.bofh.it> <qBf17-7eb-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Wed, Dec 02, 2015 at 12:45:50PM -0000, Simon Arlott wrote:
> On Tue, December 1, 2015 22:16, Mark Brown wrote:

> > Why are these in the DT, I would expect that if this is a driver for a
> > specific SoC all these properties would be known as a result of that.

> This is a driver for multiple SoCs with the same regulator control in
> different places on different SoCs, so the location of it within the misc
> register needs to be provided in the DT:

> BCM6362:
>   #define MISC_BASE 0xb0001800 /* Miscellaneous Registers */
>   uint32 miscIddqCtrl; /* 0x48 */

This is the sort of thing you can pick up from the SoC compatible
strings.  As things stand there is zero content in this driver that
relates to this SoC.

> The mask is used as there's one bit per regulator in the register, but
> there's more than one way to express this in the DT:

I wouldn't expect to see it in the device tree at all for a device
specific driver.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] regulator: Add brcm,bcm63xx-regulator device tree binding Simon Arlott <simon@fire.lp0.eu> - 2015-11-30 21:40 +0100
  [PATCH 2/2] regulator: bcm63xx: Add BCM63xx fixed regulator device Simon Arlott <simon@fire.lp0.eu> - 2015-11-30 21:40 +0100
  Re: [PATCH 1/2] regulator: Add brcm,bcm63xx-regulator device tree  binding Mark Brown <broonie@kernel.org> - 2015-12-01 23:20 +0100
    Re: [PATCH 1/2] regulator: Add brcm,bcm63xx-regulator device tree  binding "Simon Arlott" <simon@fire.lp0.eu> - 2015-12-02 13:50 +0100
      Re: [PATCH 1/2] regulator: Add brcm,bcm63xx-regulator device tree  binding Mark Brown <broonie@kernel.org> - 2015-12-02 14:00 +0100
        Re: [PATCH 1/2] regulator: Add brcm,bcm63xx-regulator device tree  binding Simon Arlott <simon@fire.lp0.eu> - 2015-12-02 21:30 +0100
          Re: [PATCH 1/2] regulator: Add brcm,bcm63xx-regulator device tree  binding Mark Brown <broonie@kernel.org> - 2015-12-03 01:10 +0100
            Re: [PATCH 1/2] regulator: Add brcm,bcm63xx-regulator device tree  binding Simon Arlott <simon@fire.lp0.eu> - 2015-12-03 09:20 +0100
              Re: [PATCH 1/2] regulator: Add brcm,bcm63xx-regulator device tree  binding Mark Brown <broonie@kernel.org> - 2015-12-03 16:10 +0100
                Re: [PATCH 1/2] regulator: Add brcm,bcm63xx-regulator device tree  binding Simon Arlott <simon@fire.lp0.eu> - 2015-12-04 00:40 +0100
                Re: [PATCH 1/2] regulator: Add brcm,bcm63xx-regulator device tree  binding Mark Brown <broonie@kernel.org> - 2015-12-04 00:50 +0100
                Re: [PATCH 1/2] regulator: Add brcm,bcm63xx-regulator device tree  binding Simon Arlott <simon@fire.lp0.eu> - 2015-12-04 01:00 +0100
                Re: [PATCH 1/2] regulator: Add brcm,bcm63xx-regulator device tree  binding Mark Brown <broonie@kernel.org> - 2015-12-04 12:10 +0100
                Re: [PATCH 1/2] regulator: Add brcm,bcm63xx-regulator device tree  binding "Simon Arlott" <simon@fire.lp0.eu> - 2015-12-04 13:30 +0100
                Re: [PATCH 1/2] regulator: Add brcm,bcm63xx-regulator device tree  binding Mark Brown <broonie@kernel.org> - 2015-12-05 18:00 +0100

csiph-web