Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1283789

Re: [PATCH 4/5] sh: ftrace: fix the comments for ftrace_modify_code

Show all headers | View raw

Hello.

On 12/4/2015 10:27 AM, Li Bin wrote:

> There is no need to worry about module and __init text disappearing
> case, because that ftrace has a module notifier that is called when
> a module is being unloaded and before the text goes away and this
> code grabs the ftrace_lock mutex and removes the module functions
> from the ftrace list, such that it will no longer do any
> modifications to that module's text, the update to make functions
> be traced or not is done under the ftrace_lock mutex as well.
> And by now, __init section codes should not been modified
> by ftrace, because it is black listed in recordmcount.c and
> ignored by ftrace.
>
> Cc: linux-sh@vger.kernel.org
> Suggested-by: Steven Rostedt <rostedt@goodmis.org>
> Signed-off-by: Li Bin <huawei.libin@huawei.com>
> ---
>   arch/sh/kernel/ftrace.c |   13 ++++++-------
>   1 files changed, 6 insertions(+), 7 deletions(-)
>
> diff --git a/arch/sh/kernel/ftrace.c b/arch/sh/kernel/ftrace.c
> index 079d70e..b696f92 100644
> --- a/arch/sh/kernel/ftrace.c
> +++ b/arch/sh/kernel/ftrace.c
> @@ -212,13 +212,12 @@ static int ftrace_modify_code(unsigned long ip, unsigned char *old_code,
>   	unsigned char replaced[MCOUNT_INSN_SIZE];
>
>   	/*
> -	 * Note: Due to modules and __init, code can
> -	 *  disappear and change, we need to protect against faulting
> -	 *  as well as code changing. We do this by using the
> -	 *  probe_kernel_* functions.
> -	 *
> -	 * No real locking needed, this code is run through
> -	 * kstop_machine, or before SMP starts.
> +	 * Note:
> +	 * We are paranoid about modifying text, as if a bug were to happen, it

    s/were/was/.

[...]

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/5] ftrace: fix ftrace misleading comments for arch using it Li Bin <huawei.libin@huawei.com> - 2015-12-04 08:30 +0100
  [PATCH 2/5] metag: ftrace: fix the comments for ftrace_modify_code Li Bin <huawei.libin@huawei.com> - 2015-12-04 08:30 +0100
  [PATCH 1/5] ia64: ftrace: fix the comments for ftrace_modify_code Li Bin <huawei.libin@huawei.com> - 2015-12-04 08:30 +0100
    RE: [PATCH 1/5] ia64: ftrace: fix the comments for  ftrace_modify_code "Luck, Tony" <tony.luck@intel.com> - 2015-12-04 18:40 +0100
  [PATCH 5/5] x86: ftrace: fix the comments for ftrace_modify_code_direct Li Bin <huawei.libin@huawei.com> - 2015-12-04 08:40 +0100
    Re: [PATCH 5/5] x86: ftrace: fix the comments for  ftrace_modify_code_direct Thomas Gleixner <tglx@linutronix.de> - 2015-12-05 18:20 +0100
      Re: [PATCH 5/5] x86: ftrace: fix the comments for  ftrace_modify_code_direct Steven Rostedt <rostedt@goodmis.org> - 2015-12-06 00:00 +0100
        Re: [PATCH 5/5] x86: ftrace: fix the comments for  ftrace_modify_code_direct Li Bin <huawei.libin@huawei.com> - 2015-12-06 03:10 +0100
  [PATCH 3/5] powerpc: ftrace: fix the comments for ftrace_modify_code Li Bin <huawei.libin@huawei.com> - 2015-12-04 08:40 +0100
  [PATCH 4/5] sh: ftrace: fix the comments for ftrace_modify_code Li Bin <huawei.libin@huawei.com> - 2015-12-04 08:40 +0100
    Re: [PATCH 4/5] sh: ftrace: fix the comments for ftrace_modify_code Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2015-12-04 13:50 +0100

csiph-web