Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1283602 > unrolled thread
| Started by | Li Bin <huawei.libin@huawei.com> |
|---|---|
| First post | 2015-12-04 08:30 +0100 |
| Last post | 2015-12-04 13:50 +0100 |
| Articles | 11 — 5 participants |
Back to article view | Back to linux.kernel
[PATCH 0/5] ftrace: fix ftrace misleading comments for arch using it Li Bin <huawei.libin@huawei.com> - 2015-12-04 08:30 +0100
[PATCH 2/5] metag: ftrace: fix the comments for ftrace_modify_code Li Bin <huawei.libin@huawei.com> - 2015-12-04 08:30 +0100
[PATCH 1/5] ia64: ftrace: fix the comments for ftrace_modify_code Li Bin <huawei.libin@huawei.com> - 2015-12-04 08:30 +0100
RE: [PATCH 1/5] ia64: ftrace: fix the comments for ftrace_modify_code "Luck, Tony" <tony.luck@intel.com> - 2015-12-04 18:40 +0100
[PATCH 5/5] x86: ftrace: fix the comments for ftrace_modify_code_direct Li Bin <huawei.libin@huawei.com> - 2015-12-04 08:40 +0100
Re: [PATCH 5/5] x86: ftrace: fix the comments for ftrace_modify_code_direct Thomas Gleixner <tglx@linutronix.de> - 2015-12-05 18:20 +0100
Re: [PATCH 5/5] x86: ftrace: fix the comments for ftrace_modify_code_direct Steven Rostedt <rostedt@goodmis.org> - 2015-12-06 00:00 +0100
Re: [PATCH 5/5] x86: ftrace: fix the comments for ftrace_modify_code_direct Li Bin <huawei.libin@huawei.com> - 2015-12-06 03:10 +0100
[PATCH 3/5] powerpc: ftrace: fix the comments for ftrace_modify_code Li Bin <huawei.libin@huawei.com> - 2015-12-04 08:40 +0100
[PATCH 4/5] sh: ftrace: fix the comments for ftrace_modify_code Li Bin <huawei.libin@huawei.com> - 2015-12-04 08:40 +0100
Re: [PATCH 4/5] sh: ftrace: fix the comments for ftrace_modify_code Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2015-12-04 13:50 +0100
| From | Li Bin <huawei.libin@huawei.com> |
|---|---|
| Date | 2015-12-04 08:30 +0100 |
| Subject | [PATCH 0/5] ftrace: fix ftrace misleading comments for arch using it |
| Message-ID | <qBSYx-863-1@gated-at.bofh.it> |
Fix the following similar misleading comments of ftrace for arch ia64/metag/powerpc/sh/x86: Note: Due to modules and __init, code can disappear and change, we need to protect against faulting as well as code changing. We do this by using the probe_kernel_* functions. No real locking needed, this code is run through kstop_machine, or before SMP starts. Cc: Tony Luck <tony.luck@intel.com> Cc: Fenghua Yu <fenghua.yu@intel.com> Cc: linux-ia64@vger.kernel.org Cc: James Hogan <james.hogan@imgtec.com> Cc: linux-metag@vger.kernel.org Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> Cc: Paul Mackerras <paulus@samba.org> Cc: Michael Ellerman <mpe@ellerman.id.au> Cc: linuxppc-dev@lists.ozlabs.org Cc: linux-sh@vger.kernel.org Cc: Thomas Gleixner <tglx@linutronix.de> "Cc: H. Peter Anvin" <hpa@zytor.com> Cc: x86@kernel.org Li Bin (5): ia64: ftrace: fix the comments for ftrace_modify_code metag: ftrace: fix the comments for ftrace_modify_code powerpc: ftrace: fix the comments for ftrace_modify_code sh: ftrace: fix the comments for ftrace_modify_code x86: ftrace: fix the comments for ftrace_modify_code_direct arch/ia64/kernel/ftrace.c | 13 ++++++------- arch/metag/kernel/ftrace.c | 12 ++++++------ arch/powerpc/kernel/ftrace.c | 13 ++++++------- arch/sh/kernel/ftrace.c | 13 ++++++------- arch/x86/kernel/ftrace.c | 13 ++++++------- 5 files changed, 30 insertions(+), 34 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Li Bin <huawei.libin@huawei.com> |
|---|---|
| Date | 2015-12-04 08:30 +0100 |
| Subject | [PATCH 2/5] metag: ftrace: fix the comments for ftrace_modify_code |
| Message-ID | <qBSYx-863-3@gated-at.bofh.it> |
| In reply to | #1283602 |
There is no need to worry about module and __init text disappearing case, because that ftrace has a module notifier that is called when a module is being unloaded and before the text goes away and this code grabs the ftrace_lock mutex and removes the module functions from the ftrace list, such that it will no longer do any modifications to that module's text, the update to make functions be traced or not is done under the ftrace_lock mutex as well. And by now, __init section codes should not been modified by ftrace, because it is black listed in recordmcount.c and ignored by ftrace. Cc: James Hogan <james.hogan@imgtec.com> Cc: linux-metag@vger.kernel.org Suggested-by: Steven Rostedt <rostedt@goodmis.org> Signed-off-by: Li Bin <huawei.libin@huawei.com> --- arch/metag/kernel/ftrace.c | 12 ++++++------ 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/arch/metag/kernel/ftrace.c b/arch/metag/kernel/ftrace.c index ed1d685..e5d71b1 100644 --- a/arch/metag/kernel/ftrace.c +++ b/arch/metag/kernel/ftrace.c @@ -54,12 +54,12 @@ static int ftrace_modify_code(unsigned long pc, unsigned char *old_code, unsigned char replaced[MCOUNT_INSN_SIZE]; /* - * Note: Due to modules and __init, code can - * disappear and change, we need to protect against faulting - * as well as code changing. - * - * No real locking needed, this code is run through - * kstop_machine. + * Note: + * We are paranoid about modifying text, as if a bug were to happen, it + * could cause us to read or write to someplace that could cause harm. + * Carefully read and modify the code with aarch64_insn_*() which uses + * probe_kernel_*(), and make sure what we read is what we expected it + * to be before modifying it. */ /* read the text we want to modify */ -- 1.7.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Li Bin <huawei.libin@huawei.com> |
|---|---|
| Date | 2015-12-04 08:30 +0100 |
| Subject | [PATCH 1/5] ia64: ftrace: fix the comments for ftrace_modify_code |
| Message-ID | <qBSYx-863-5@gated-at.bofh.it> |
| In reply to | #1283602 |
There is no need to worry about module and __init text disappearing case, because that ftrace has a module notifier that is called when a module is being unloaded and before the text goes away and this code grabs the ftrace_lock mutex and removes the module functions from the ftrace list, such that it will no longer do any modifications to that module's text, the update to make functions be traced or not is done under the ftrace_lock mutex as well. And by now, __init section codes should not been modified by ftrace, because it is black listed in recordmcount.c and ignored by ftrace. Cc: Tony Luck <tony.luck@intel.com> Cc: Fenghua Yu <fenghua.yu@intel.com> Cc: linux-ia64@vger.kernel.org Suggested-by: Steven Rostedt <rostedt@goodmis.org> Signed-off-by: Li Bin <huawei.libin@huawei.com> --- arch/ia64/kernel/ftrace.c | 13 ++++++------- 1 files changed, 6 insertions(+), 7 deletions(-) diff --git a/arch/ia64/kernel/ftrace.c b/arch/ia64/kernel/ftrace.c index 3b0c2aa..a48a3f4 100644 --- a/arch/ia64/kernel/ftrace.c +++ b/arch/ia64/kernel/ftrace.c @@ -97,13 +97,12 @@ ftrace_modify_code(unsigned long ip, unsigned char *old_code, unsigned char replaced[MCOUNT_INSN_SIZE]; /* - * Note: Due to modules and __init, code can - * disappear and change, we need to protect against faulting - * as well as code changing. We do this by using the - * probe_kernel_* functions. - * - * No real locking needed, this code is run through - * kstop_machine, or before SMP starts. + * Note: + * We are paranoid about modifying text, as if a bug were to happen, it + * could cause us to read or write to someplace that could cause harm. + * Carefully read and modify the code with aarch64_insn_*() which uses + * probe_kernel_*(), and make sure what we read is what we expected it + * to be before modifying it. */ if (!do_check) -- 1.7.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | "Luck, Tony" <tony.luck@intel.com> |
|---|---|
| Date | 2015-12-04 18:40 +0100 |
| Subject | RE: [PATCH 1/5] ia64: ftrace: fix the comments for ftrace_modify_code |
| Message-ID | <qC2uR-5Kw-7@gated-at.bofh.it> |
| In reply to | #1283604 |
> Suggested-by: Steven Rostedt <rostedt@goodmis.org> > Signed-off-by: Li Bin <huawei.libin@huawei.com> Sure. Acked-by: Tony Luck <tomy.luck@intel.com> [assuming that Steven is going to apply this whole series] -Tony -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Li Bin <huawei.libin@huawei.com> |
|---|---|
| Date | 2015-12-04 08:40 +0100 |
| Subject | [PATCH 5/5] x86: ftrace: fix the comments for ftrace_modify_code_direct |
| Message-ID | <qBT8d-89d-1@gated-at.bofh.it> |
| In reply to | #1283602 |
There is no need to worry about module and __init text disappearing case, because that ftrace has a module notifier that is called when a module is being unloaded and before the text goes away and this code grabs the ftrace_lock mutex and removes the module functions from the ftrace list, such that it will no longer do any modifications to that module's text, the update to make functions be traced or not is done under the ftrace_lock mutex as well. And by now, __init section codes should not been modified by ftrace, because it is black listed in recordmcount.c and ignored by ftrace. Cc: Thomas Gleixner <tglx@linutronix.de> Cc: "H. Peter Anvin" <hpa@zytor.com> Cc: x86@kernel.org Suggested-by: Steven Rostedt <rostedt@goodmis.org> Signed-off-by: Li Bin <huawei.libin@huawei.com> --- arch/x86/kernel/ftrace.c | 13 ++++++------- 1 files changed, 6 insertions(+), 7 deletions(-) diff --git a/arch/x86/kernel/ftrace.c b/arch/x86/kernel/ftrace.c index 311bcf3..c2987e8 100644 --- a/arch/x86/kernel/ftrace.c +++ b/arch/x86/kernel/ftrace.c @@ -106,13 +106,12 @@ ftrace_modify_code_direct(unsigned long ip, unsigned const char *old_code, unsigned char replaced[MCOUNT_INSN_SIZE]; /* - * Note: Due to modules and __init, code can - * disappear and change, we need to protect against faulting - * as well as code changing. We do this by using the - * probe_kernel_* functions. - * - * No real locking needed, this code is run through - * kstop_machine, or before SMP starts. + * Note: + * We are paranoid about modifying text, as if a bug were to happen, it + * could cause us to read or write to someplace that could cause harm. + * Carefully read and modify the code with aarch64_insn_*() which uses + * probe_kernel_*(), and make sure what we read is what we expected it + * to be before modifying it. */ /* read the text we want to modify */ -- 1.7.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Thomas Gleixner <tglx@linutronix.de> |
|---|---|
| Date | 2015-12-05 18:20 +0100 |
| Subject | Re: [PATCH 5/5] x86: ftrace: fix the comments for ftrace_modify_code_direct |
| Message-ID | <qCoF4-3UB-13@gated-at.bofh.it> |
| In reply to | #1283606 |
On Fri, 4 Dec 2015, Li Bin wrote: > --- a/arch/x86/kernel/ftrace.c > +++ b/arch/x86/kernel/ftrace.c > @@ -106,13 +106,12 @@ ftrace_modify_code_direct(unsigned long ip, unsigned const char *old_code, > unsigned char replaced[MCOUNT_INSN_SIZE]; > > /* > - * Note: Due to modules and __init, code can > - * disappear and change, we need to protect against faulting > - * as well as code changing. We do this by using the > - * probe_kernel_* functions. > - * > - * No real locking needed, this code is run through > - * kstop_machine, or before SMP starts. > + * Note: > + * We are paranoid about modifying text, as if a bug were to happen, it > + * could cause us to read or write to someplace that could cause harm. > + * Carefully read and modify the code with aarch64_insn_*() which uses aarch64_insn_() is related to x86 in which way? Thanks, tglx -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Steven Rostedt <rostedt@goodmis.org> |
|---|---|
| Date | 2015-12-06 00:00 +0100 |
| Subject | Re: [PATCH 5/5] x86: ftrace: fix the comments for ftrace_modify_code_direct |
| Message-ID | <qCtY6-740-25@gated-at.bofh.it> |
| In reply to | #1284600 |
On Sat, 5 Dec 2015 18:12:57 +0100 (CET) Thomas Gleixner <tglx@linutronix.de> wrote: > On Fri, 4 Dec 2015, Li Bin wrote: > > --- a/arch/x86/kernel/ftrace.c > > +++ b/arch/x86/kernel/ftrace.c > > @@ -106,13 +106,12 @@ ftrace_modify_code_direct(unsigned long ip, unsigned const char *old_code, > > unsigned char replaced[MCOUNT_INSN_SIZE]; > > > > /* > > - * Note: Due to modules and __init, code can > > - * disappear and change, we need to protect against faulting > > - * as well as code changing. We do this by using the > > - * probe_kernel_* functions. > > - * > > - * No real locking needed, this code is run through > > - * kstop_machine, or before SMP starts. > > + * Note: > > + * We are paranoid about modifying text, as if a bug were to happen, it > > + * could cause us to read or write to someplace that could cause harm. > > + * Carefully read and modify the code with aarch64_insn_*() which uses > > aarch64_insn_() is related to x86 in which way? > > The original comment is incorrect and we discussed this with the arm64 code, and said the other archs need the comment updated as well. But it seems that Li Bin just cut and pasted the arm64 patch for the other archs, or at least with x86 (haven't looked at the others yet). This needs to be fixed. -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Li Bin <huawei.libin@huawei.com> |
|---|---|
| Date | 2015-12-06 03:10 +0100 |
| Subject | Re: [PATCH 5/5] x86: ftrace: fix the comments for ftrace_modify_code_direct |
| Message-ID | <qCwVY-GI-13@gated-at.bofh.it> |
| In reply to | #1284659 |
on 2015/12/6 6:52, Steven Rostedt wrote: > On Sat, 5 Dec 2015 18:12:57 +0100 (CET) > Thomas Gleixner <tglx@linutronix.de> wrote: > >> On Fri, 4 Dec 2015, Li Bin wrote: >>> --- a/arch/x86/kernel/ftrace.c >>> +++ b/arch/x86/kernel/ftrace.c >>> @@ -106,13 +106,12 @@ ftrace_modify_code_direct(unsigned long ip, unsigned const char *old_code, >>> unsigned char replaced[MCOUNT_INSN_SIZE]; >>> >>> /* >>> - * Note: Due to modules and __init, code can >>> - * disappear and change, we need to protect against faulting >>> - * as well as code changing. We do this by using the >>> - * probe_kernel_* functions. >>> - * >>> - * No real locking needed, this code is run through >>> - * kstop_machine, or before SMP starts. >>> + * Note: >>> + * We are paranoid about modifying text, as if a bug were to happen, it >>> + * could cause us to read or write to someplace that could cause harm. >>> + * Carefully read and modify the code with aarch64_insn_*() which uses >> aarch64_insn_() is related to x86 in which way? >> >> > The original comment is incorrect and we discussed this with the > arm64 code, and said the other archs need the comment updated as > well. But it seems that Li Bin just cut and pasted the arm64 patch for > the other archs, or at least with x86 (haven't looked at the others > yet). This needs to be fixed. Sorry for my mistake, I will modify it. Thanks, Li Bin > -- Steve > > . > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Li Bin <huawei.libin@huawei.com> |
|---|---|
| Date | 2015-12-04 08:40 +0100 |
| Subject | [PATCH 3/5] powerpc: ftrace: fix the comments for ftrace_modify_code |
| Message-ID | <qBT8d-89d-5@gated-at.bofh.it> |
| In reply to | #1283602 |
There is no need to worry about module and __init text disappearing case, because that ftrace has a module notifier that is called when a module is being unloaded and before the text goes away and this code grabs the ftrace_lock mutex and removes the module functions from the ftrace list, such that it will no longer do any modifications to that module's text, the update to make functions be traced or not is done under the ftrace_lock mutex as well. And by now, __init section codes should not been modified by ftrace, because it is black listed in recordmcount.c and ignored by ftrace. Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> Cc: Paul Mackerras <paulus@samba.org> Cc: Michael Ellerman <mpe@ellerman.id.au> Cc: linuxppc-dev@lists.ozlabs.org Suggested-by: Steven Rostedt <rostedt@goodmis.org> Signed-off-by: Li Bin <huawei.libin@huawei.com> --- arch/powerpc/kernel/ftrace.c | 13 ++++++------- 1 files changed, 6 insertions(+), 7 deletions(-) diff --git a/arch/powerpc/kernel/ftrace.c b/arch/powerpc/kernel/ftrace.c index 44d4d8e..c6452b2 100644 --- a/arch/powerpc/kernel/ftrace.c +++ b/arch/powerpc/kernel/ftrace.c @@ -47,13 +47,12 @@ ftrace_modify_code(unsigned long ip, unsigned int old, unsigned int new) unsigned int replaced; /* - * Note: Due to modules and __init, code can - * disappear and change, we need to protect against faulting - * as well as code changing. We do this by using the - * probe_kernel_* functions. - * - * No real locking needed, this code is run through - * kstop_machine, or before SMP starts. + * Note: + * We are paranoid about modifying text, as if a bug were to happen, it + * could cause us to read or write to someplace that could cause harm. + * Carefully read and modify the code with aarch64_insn_*() which uses + * probe_kernel_*(), and make sure what we read is what we expected it + * to be before modifying it. */ /* read the text we want to modify */ -- 1.7.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Li Bin <huawei.libin@huawei.com> |
|---|---|
| Date | 2015-12-04 08:40 +0100 |
| Subject | [PATCH 4/5] sh: ftrace: fix the comments for ftrace_modify_code |
| Message-ID | <qBT8d-89d-9@gated-at.bofh.it> |
| In reply to | #1283602 |
There is no need to worry about module and __init text disappearing case, because that ftrace has a module notifier that is called when a module is being unloaded and before the text goes away and this code grabs the ftrace_lock mutex and removes the module functions from the ftrace list, such that it will no longer do any modifications to that module's text, the update to make functions be traced or not is done under the ftrace_lock mutex as well. And by now, __init section codes should not been modified by ftrace, because it is black listed in recordmcount.c and ignored by ftrace. Cc: linux-sh@vger.kernel.org Suggested-by: Steven Rostedt <rostedt@goodmis.org> Signed-off-by: Li Bin <huawei.libin@huawei.com> --- arch/sh/kernel/ftrace.c | 13 ++++++------- 1 files changed, 6 insertions(+), 7 deletions(-) diff --git a/arch/sh/kernel/ftrace.c b/arch/sh/kernel/ftrace.c index 079d70e..b696f92 100644 --- a/arch/sh/kernel/ftrace.c +++ b/arch/sh/kernel/ftrace.c @@ -212,13 +212,12 @@ static int ftrace_modify_code(unsigned long ip, unsigned char *old_code, unsigned char replaced[MCOUNT_INSN_SIZE]; /* - * Note: Due to modules and __init, code can - * disappear and change, we need to protect against faulting - * as well as code changing. We do this by using the - * probe_kernel_* functions. - * - * No real locking needed, this code is run through - * kstop_machine, or before SMP starts. + * Note: + * We are paranoid about modifying text, as if a bug were to happen, it + * could cause us to read or write to someplace that could cause harm. + * Carefully read and modify the code with aarch64_insn_*() which uses + * probe_kernel_*(), and make sure what we read is what we expected it + * to be before modifying it. */ /* read the text we want to modify */ -- 1.7.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> |
|---|---|
| Date | 2015-12-04 13:50 +0100 |
| Subject | Re: [PATCH 4/5] sh: ftrace: fix the comments for ftrace_modify_code |
| Message-ID | <qBXYe-2HT-15@gated-at.bofh.it> |
| In reply to | #1283608 |
Hello.
On 12/4/2015 10:27 AM, Li Bin wrote:
> There is no need to worry about module and __init text disappearing
> case, because that ftrace has a module notifier that is called when
> a module is being unloaded and before the text goes away and this
> code grabs the ftrace_lock mutex and removes the module functions
> from the ftrace list, such that it will no longer do any
> modifications to that module's text, the update to make functions
> be traced or not is done under the ftrace_lock mutex as well.
> And by now, __init section codes should not been modified
> by ftrace, because it is black listed in recordmcount.c and
> ignored by ftrace.
>
> Cc: linux-sh@vger.kernel.org
> Suggested-by: Steven Rostedt <rostedt@goodmis.org>
> Signed-off-by: Li Bin <huawei.libin@huawei.com>
> ---
> arch/sh/kernel/ftrace.c | 13 ++++++-------
> 1 files changed, 6 insertions(+), 7 deletions(-)
>
> diff --git a/arch/sh/kernel/ftrace.c b/arch/sh/kernel/ftrace.c
> index 079d70e..b696f92 100644
> --- a/arch/sh/kernel/ftrace.c
> +++ b/arch/sh/kernel/ftrace.c
> @@ -212,13 +212,12 @@ static int ftrace_modify_code(unsigned long ip, unsigned char *old_code,
> unsigned char replaced[MCOUNT_INSN_SIZE];
>
> /*
> - * Note: Due to modules and __init, code can
> - * disappear and change, we need to protect against faulting
> - * as well as code changing. We do this by using the
> - * probe_kernel_* functions.
> - *
> - * No real locking needed, this code is run through
> - * kstop_machine, or before SMP starts.
> + * Note:
> + * We are paranoid about modifying text, as if a bug were to happen, it
s/were/was/.
[...]
MBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web