Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1281248
| From | Grant Grundler <grantgrundler@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] parisc: Remove unused pcibios_init_bus() |
| Date | 2015-12-01 23:10 +0100 |
| Message-ID | <qB1hy-73C-29@gated-at.bofh.it> (permalink) |
| References | <qAWhQ-3F3-21@gated-at.bofh.it> <qB026-65N-21@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tue, Dec 1, 2015 at 12:44 PM, Helge Deller <deller@gmx.de> wrote: > On 01.12.2015 17:41, Bjorn Helgaas wrote: >> There are no callers of pcibios_init_bus(), so remove it. > > True, pcibios_init_bus() isn't called anywhere, so it should be removed. > > But I wonder if we might need to initialize latency and parity for PCI-PCI > bridges somewhere else then? pcibios_fixup_bus() appears to do that...but I don't know the call chain. I used cscope to look for PCI_BRIDGE_CTL_PARITY. > In one of my machines I have a i960 based RAID controller which isn't working > yet (I think it's internally based on a PCI-PCI bridge), and maybe this > is the reason it doesn't work? I will need to test it (e.g. firmware doesn't > fully initializes PCI-PCI bridges, which is why this code was added once). If lspci doesn't show the PCI-PCI bridge, the i960 RAID card is using that internally. parisc (and any other architecture) should discover and configure all PCI-PCI bridges already. I know it did for the "multifunction" cards I had available 10 years ago. cheers, grant -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] parisc: Remove unused pcibios_init_bus() Bjorn Helgaas <bhelgaas@google.com> - 2015-12-01 17:50 +0100
Re: [PATCH] parisc: Remove unused pcibios_init_bus() Helge Deller <deller@gmx.de> - 2015-12-01 21:50 +0100
Re: [PATCH] parisc: Remove unused pcibios_init_bus() Grant Grundler <grantgrundler@gmail.com> - 2015-12-01 23:10 +0100
Re: [PATCH] parisc: Remove unused pcibios_init_bus() Helge Deller <deller@gmx.de> - 2015-12-03 20:50 +0100
csiph-web