Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1281247
| From | Valdis Kletnieks <Valdis.Kletnieks@vt.edu> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [lustre cleanups 6/6] Nuke another unsigned >= 0 assert |
| Date | 2015-12-01 23:10 +0100 |
| Message-ID | <qB1hy-73C-27@gated-at.bofh.it> (permalink) |
| References | <qB1hw-73C-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Clean up another case of the compiler remininding the programmer they
are an idiot:
drivers/staging/lustre/lustre/ptlrpc/sec_bulk.c:308:34: warning: comparison of u
nsigned expression >= 0 is always true [-Wtype-limits]
LASSERT(page_pools.epp_waitqlen >= 0);
Just lose the assert, and save a page of compiler spew.
Signed-off-by: Valdis Kletnieks <Valdis.Kletnieks@vt.edu>
---
diff --git a/drivers/staging/lustre/lustre/ptlrpc/sec_bulk.c b/drivers/staging/lustre/lustre/ptlrpc/sec_bulk.c
index cd8a9987f7ac..1f326673f089 100644
--- a/drivers/staging/lustre/lustre/ptlrpc/sec_bulk.c
+++ b/drivers/staging/lustre/lustre/ptlrpc/sec_bulk.c
@@ -304,7 +304,6 @@ static unsigned long enc_pools_cleanup(struct page ***pools, int npools)
static inline void enc_pools_wakeup(void)
{
assert_spin_locked(&page_pools.epp_lock);
- LASSERT(page_pools.epp_waitqlen >= 0);
if (unlikely(page_pools.epp_waitqlen)) {
LASSERT(waitqueue_active(&page_pools.epp_waitq));
--
2.6.3
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[lustre cleanups 0/6] Patch series to make lustre safe(r) for W=1 compiles Valdis Kletnieks <Valdis.Kletnieks@vt.edu> - 2015-12-01 23:10 +0100 [lustre cleanups 4/6] Fix another C compiler whine: Valdis Kletnieks <Valdis.Kletnieks@vt.edu> - 2015-12-01 23:10 +0100 [lustre cleanups 1/6] Swap inline/const to kill 272 warnings Valdis Kletnieks <Valdis.Kletnieks@vt.edu> - 2015-12-01 23:10 +0100 [lustre cleanups 3/6] Clean up another C warnining: Valdis Kletnieks <Valdis.Kletnieks@vt.edu> - 2015-12-01 23:10 +0100 [lustre cleanups 6/6] Nuke another unsigned >= 0 assert Valdis Kletnieks <Valdis.Kletnieks@vt.edu> - 2015-12-01 23:10 +0100 [lustre cleanups 5/6] Nuke an unsigned >= 0 assert Valdis Kletnieks <Valdis.Kletnieks@vt.edu> - 2015-12-01 23:10 +0100 Re: [lustre cleanups 0/6] Patch series to make lustre safe(r) for W=1 compiles "Dilger, Andreas" <andreas.dilger@intel.com> - 2015-12-04 07:30 +0100
csiph-web