Re: [PATCH 1/2] extcon: add driver for Intel USB mux

From	Felipe Balbi <balbi@ti.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] extcon: add driver for Intel USB mux
Date	2015-12-01 22:30 +0100
Message-ID	<qB0EO-6zP-29@gated-at.bofh.it> (permalink)
References	<qATjY-1Oq-9@gated-at.bofh.it> <qATjY-1Oq-19@gated-at.bofh.it> <qAZSr-622-33@gated-at.bofh.it> <qB0bL-6as-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi,

David Cohen <david.a.cohen@linux.intel.com> writes:
> Hi Felipe,
>
> On Tue, Dec 01, 2015 at 02:34:34PM -0600, Felipe Balbi wrote:
>
> [snip]
>
>> > +EXPORT_SYMBOL_GPL(intel_usb_mux_register);
>> > +
>> > +void intel_usb_mux_unregister(struct intel_usb_mux *mux)
>> > +{
>> > +	extcon_unregister_notifier(&mux->edev, EXTCON_USB_HOST, &mux->nb);
>> > +	extcon_dev_unregister(&mux->edev);
>> > +	writel(mux->cfg0_ctx, mux->regs + INTEL_MUX_CFG0);
>> > +	iounmap(mux->regs);
>> > +	kfree(mux);
>> > +}
>> > +EXPORT_SYMBOL_GPL(intel_usb_mux_unregister);
>> 
>> so who's gonna call these two functions ? IMO, this looks like a recipe
>> for randbuild breakage.
>
> There are function stubs on header file when the functions aren't
> available.
> But also notice CONFIG_EXTCON_INTEL_USB is not user-selectable. It's
> automatically selected when a driver that requires it is selected too.
>
> With the 2 cases above, IMHO it should not bring issues with randbuild
> tests.

right now it won't break, that's correct :-) But things change over time
and this is, at least, fragile. I mean, why couldn't this mux be an
actual driver ?

-- 
balbi

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] extcon: add driver for Intel USB mux Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2015-12-01 14:40 +0100
  Re: [PATCH 1/2] extcon: add driver for Intel USB mux David Cohen <david.a.cohen@linux.intel.com> - 2015-12-01 21:30 +0100
    Re: [PATCH 1/2] extcon: add driver for Intel USB mux Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2015-12-02 11:30 +0100
      Re: [PATCH 1/2] extcon: add driver for Intel USB mux David Cohen <david.a.cohen@linux.intel.com> - 2015-12-02 19:20 +0100
  Re: [PATCH 1/2] extcon: add driver for Intel USB mux Felipe Balbi <balbi@ti.com> - 2015-12-01 21:40 +0100
    Re: [PATCH 1/2] extcon: add driver for Intel USB mux David Cohen <david.a.cohen@linux.intel.com> - 2015-12-01 22:00 +0100
      Re: [PATCH 1/2] extcon: add driver for Intel USB mux Felipe Balbi <balbi@ti.com> - 2015-12-01 22:30 +0100

csiph-web