Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1281210

Re: [PATCH 1/2] extcon: add driver for Intel USB mux

Show all headers | View raw

Hi Felipe,

On Tue, Dec 01, 2015 at 02:34:34PM -0600, Felipe Balbi wrote:

[snip]

> > +EXPORT_SYMBOL_GPL(intel_usb_mux_register);
> > +
> > +void intel_usb_mux_unregister(struct intel_usb_mux *mux)
> > +{
> > +	extcon_unregister_notifier(&mux->edev, EXTCON_USB_HOST, &mux->nb);
> > +	extcon_dev_unregister(&mux->edev);
> > +	writel(mux->cfg0_ctx, mux->regs + INTEL_MUX_CFG0);
> > +	iounmap(mux->regs);
> > +	kfree(mux);
> > +}
> > +EXPORT_SYMBOL_GPL(intel_usb_mux_unregister);
> 
> so who's gonna call these two functions ? IMO, this looks like a recipe
> for randbuild breakage.

There are function stubs on header file when the functions aren't
available.
But also notice CONFIG_EXTCON_INTEL_USB is not user-selectable. It's
automatically selected when a driver that requires it is selected too.

With the 2 cases above, IMHO it should not bring issues with randbuild
tests.

Br, David

> 
> -- 
> balbi


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] extcon: add driver for Intel USB mux Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2015-12-01 14:40 +0100
  Re: [PATCH 1/2] extcon: add driver for Intel USB mux David Cohen <david.a.cohen@linux.intel.com> - 2015-12-01 21:30 +0100
    Re: [PATCH 1/2] extcon: add driver for Intel USB mux Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2015-12-02 11:30 +0100
      Re: [PATCH 1/2] extcon: add driver for Intel USB mux David Cohen <david.a.cohen@linux.intel.com> - 2015-12-02 19:20 +0100
  Re: [PATCH 1/2] extcon: add driver for Intel USB mux Felipe Balbi <balbi@ti.com> - 2015-12-01 21:40 +0100
    Re: [PATCH 1/2] extcon: add driver for Intel USB mux David Cohen <david.a.cohen@linux.intel.com> - 2015-12-01 22:00 +0100
      Re: [PATCH 1/2] extcon: add driver for Intel USB mux Felipe Balbi <balbi@ti.com> - 2015-12-01 22:30 +0100

csiph-web