Re: [PATCH] brcmnand: Clear EXT_ADDR error registers in PIO mode

From	Brian Norris <computersforpeace@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] brcmnand: Clear EXT_ADDR error registers in PIO mode
Date	2015-12-01 03:00 +0100
Message-ID	<qAIoy-360-25@gated-at.bofh.it> (permalink)
References	<qvA8h-4Gl-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Nov 16, 2015 at 10:05:39PM +0000, Simon Arlott wrote:
> If an error occurs in flash above 4GB in PIO mode then the EXT_ADDR
> registers will be set to the location of the error and never cleared.
> 
> Reset them to 0 before reading.
> 
> Signed-off-by: Simon Arlott <simon@fire.lp0.eu>
> ---
>  drivers/mtd/nand/brcmnand/brcmnand.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/mtd/nand/brcmnand/brcmnand.c b/drivers/mtd/nand/brcmnand/brcmnand.c
> index 12c6190..2c8f67f 100644
> --- a/drivers/mtd/nand/brcmnand/brcmnand.c
> +++ b/drivers/mtd/nand/brcmnand/brcmnand.c
> @@ -1400,6 +1400,8 @@ static int brcmnand_read_by_pio(struct mtd_info *mtd, struct nand_chip *chip,
>  	/* Clear error addresses */
>  	brcmnand_write_reg(ctrl, BRCMNAND_UNCORR_ADDR, 0);
>  	brcmnand_write_reg(ctrl, BRCMNAND_CORR_ADDR, 0);
> +	brcmnand_write_reg(ctrl, BRCMNAND_UNCORR_EXT_ADDR, 0);
> +	brcmnand_write_reg(ctrl, BRCMNAND_CORR_EXT_ADDR, 0);
>  
>  	brcmnand_write_reg(ctrl, BRCMNAND_CMD_EXT_ADDRESS,
>  			(host->cs << 16) | ((addr >> 32) & 0xffff));

Applied to l2-mtd.git
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] brcmnand: Clear EXT_ADDR error registers in PIO mode Simon Arlott <simon@fire.lp0.eu> - 2015-11-16 23:10 +0100
  Re: [PATCH] brcmnand: Clear EXT_ADDR error registers in PIO mode Brian Norris <computersforpeace@gmail.com> - 2015-11-17 01:50 +0100
    Re: [PATCH] brcmnand: Clear EXT_ADDR error registers in PIO mode Simon Arlott <simon@fire.lp0.eu> - 2015-11-17 08:50 +0100
      Re: [PATCH] brcmnand: Clear EXT_ADDR error registers in PIO mode Brian Norris <computersforpeace@gmail.com> - 2015-11-17 19:00 +0100
        Re: [PATCH] brcmnand: Clear EXT_ADDR error registers in PIO mode Simon Arlott <simon@fire.lp0.eu> - 2015-11-20 19:50 +0100
          Re: [PATCH] brcmnand: Clear EXT_ADDR error registers in PIO mode Brian Norris <computersforpeace@gmail.com> - 2015-12-01 02:50 +0100
  Re: [PATCH] brcmnand: Clear EXT_ADDR error registers in PIO mode Brian Norris <computersforpeace@gmail.com> - 2015-12-01 03:00 +0100

csiph-web